-
Notifications
You must be signed in to change notification settings - Fork 1.2k
test(e2e): Fix all known screenshot test flakes #2878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,72 @@ | ||
// kilocode_change - new file | ||
import { type Page } from "@playwright/test" | ||
|
||
/** | ||
* Waits for DOM stability by injecting a MutationObserver into the page. | ||
* Monitors all DOM changes and waits for 250ms of inactivity before resolving. | ||
* Includes a 10-second timeout to prevent infinite waiting. | ||
* | ||
* @param page - The Playwright page instance | ||
* @returns Promise that resolves when DOM is stable or timeout occurs | ||
*/ | ||
export async function waitForDOMStability(page: Page): Promise<void> { | ||
await page.evaluate(() => { | ||
return new Promise<void>((resolve) => { | ||
const DEBOUNCE_DELAY = 250 // ms | ||
const MAX_TIMEOUT = 10000 // ms | ||
|
||
let debounceTimer: NodeJS.Timeout | null = null | ||
let timeoutTimer: NodeJS.Timeout | null = null | ||
let observer: MutationObserver | null = null | ||
|
||
const cleanup = () => { | ||
if (debounceTimer) { | ||
clearTimeout(debounceTimer) | ||
debounceTimer = null | ||
} | ||
if (timeoutTimer) { | ||
clearTimeout(timeoutTimer) | ||
timeoutTimer = null | ||
} | ||
if (observer) { | ||
observer.disconnect() | ||
observer = null | ||
} | ||
} | ||
|
||
const resolveStability = () => { | ||
cleanup() | ||
resolve() | ||
} | ||
|
||
const resetDebounceTimer = () => { | ||
if (debounceTimer) { | ||
clearTimeout(debounceTimer) | ||
} | ||
debounceTimer = setTimeout(resolveStability, DEBOUNCE_DELAY) | ||
} | ||
|
||
// Set up maximum timeout protection | ||
timeoutTimer = setTimeout(() => { | ||
console.log("DOM stability timeout reached (10s)") | ||
resolveStability() | ||
}, MAX_TIMEOUT) | ||
|
||
// Create and configure MutationObserver | ||
observer = new MutationObserver(() => { | ||
resetDebounceTimer() | ||
}) | ||
|
||
// Start observing all types of DOM changes | ||
observer.observe(document.body, { | ||
childList: true, // Node additions/removals | ||
attributes: true, // Attribute changes | ||
characterData: true, // Text content changes | ||
subtree: true, // Monitor entire DOM tree | ||
}) | ||
|
||
// Start initial debounce timer | ||
resetDebounceTimer() | ||
}) | ||
}) | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,15 @@ | ||
// kilocode_change - new file | ||
import { type Page } from "@playwright/test" | ||
import { waitForWebviewText, configureApiKeyThroughUI } from "./webview-helpers" | ||
import { verifyExtensionInstalled } from "./vscode-helpers" | ||
import { waitForWebviewText, configureApiKeyThroughUI, waitForModelSelector } from "./webview-helpers" | ||
import { verifyExtensionInstalled, waitForAllExtensionActivation } from "./vscode-helpers" | ||
|
||
export async function setupTestEnvironment(page: Page): Promise<void> { | ||
await waitForAllExtensionActivation(page) | ||
|
||
await verifyExtensionInstalled(page) | ||
await waitForWebviewText(page, "Welcome to Kilo Code!") | ||
|
||
await configureApiKeyThroughUI(page) | ||
await waitForWebviewText(page, "Generate, refactor, and debug code with AI assistance") | ||
|
||
await waitForModelSelector(page) | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notification closing is now built into
takeScreenshot