Repo update #220
Merged
Repo update #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
smoya23
commented
May 23, 2024
smoya23
commented
- Creating a specific launch file for Gen3 Lite robots
- Fixing and updating the MoveIt configs for Gen3 robots
- Restructuring documentation for clarity
martinleroux
requested changes
May 23, 2024
|
|
||
| * `gripper` : Gripper to use. Possible values for the Gen3 are either `robotiq_2f_85` or `robotiq_2f_140`. For the Gen3 Lite, the only option is `gen3_lite_2f`. Default value is an empty string, which will display the arm without a gripper. | ||
|
|
||
| * `dof` : Degrees of freedom of the arm. Possible values for the Gen3 are either `6` or `7`. For the Gen3 Lite, the only option is `6`. Default value is `7`. |
There was a problem hiding this comment.
Can we have the logic so the argument is ignored for Gen3 lite? To avoid problems with the default value.
There was a problem hiding this comment.
Good point, I removed the argument completely from the launch file and set the value to 6
README.md
Outdated
|
|
||
| * `fake_sensor_commands` : Enable fake command interfaces for sensors used for simple simulations. Used only if 'use_fake_hardware' parameter is true. Default value is `false`. | ||
|
|
||
| * `robot_controller` : Robot controller to start. Default value is `joint_trajectory_controller`. |
There was a problem hiding this comment.
Are there other options?
| use_internal_bus_gripper_comm:=true | ||
| gripper_joint_name:=right_finger_bottom_joint | ||
| tf_prefix:='' | ||
| robot_ip:=192.168.1.10 |
There was a problem hiding this comment.
Add a comment: 192.168.2.10 when using USB to Ethernet interface instead of USB via RNDIS
There was a problem hiding this comment.
Added comment in the README arguments explanation
smoya23
force-pushed
the
pr_gen3-lite-launch-file
branch
from
c3c03e9 to
38bff1f
Compare
martinleroux
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.