Migrate from Webpack and Jest to Vite and Vitest #3104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grahamalama
commented
Jan 12, 2024
There was a problem hiding this comment.
This was mostly me trying to merge our old tsconfig with what was provided by their template
alexcottner
approved these changes
Jan 12, 2024
|
Note that this PR changes one of the environment variables used when building the bundle -- - SINGLE_SERVER
+ KINTO_ADMIN_SINGLE_SERVERwe'll need to account for this in the build process. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR all started when I was investigating mozilla/remote-settings#522
I suspected some rerendering was causing elements to go stale, so I fired up Kinto Admin and went to look at the profiler only to discover that React thought we were running a production build.
I went to make the necessary configuration changes to enable a development build, but I quickly became disheartened by the task of modifying Webpack config.
I then though about how Webpack is pretty slow in general, compared to newer tools. I tried out a few different bundlers (esbuild, parcel, Vite), and Vite seemed to be the easiest to use and was faster that Webpack.
I made that change, but then quickly found out that
Jestis incompatible with Vite. I searched for answers there as well and found https://vitest.dev/, which is the "part 2" of this PR. Migrating to Vitest also seemed to expose some errors in our testsOverall after this PR, we have:
Some of the changes in this PR required mass find-and-replaces (d84f5f3 and e0d1815), so I'd recommend stepping through by commit.