Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SketchOnFace UI #1664

Merged
merged 51 commits into from
Mar 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
51 commits
Select commit Hold shift + click to select a range
080e5de
always enter edit mode
Irev-Dev Mar 6, 2024
8a65fbe
initial blocking of extra code-mirror updates
Irev-Dev Mar 7, 2024
64d4879
dry out code
Irev-Dev Mar 7, 2024
3922e63
rejig selections
Irev-Dev Mar 7, 2024
406fca4
A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu)
github-actions[bot] Mar 7, 2024
7d5246e
clean up
Irev-Dev Mar 7, 2024
476c164
stream clean up
Irev-Dev Mar 7, 2024
fdcd9e4
update export
Irev-Dev Mar 7, 2024
39d1507
sketch mode can be entered and exited for extrude faces
Irev-Dev Mar 8, 2024
6550605
startSketchOn working in some cases, editsketch animation working but…
Irev-Dev Mar 9, 2024
12f8055
Revert "A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu)"
Irev-Dev Mar 9, 2024
f76edbc
Merge remote-tracking branch 'origin' into kurt-selections-refactor
Irev-Dev Mar 9, 2024
fecf6f4
A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu)
github-actions[bot] Mar 9, 2024
45e2f92
remove comment
Irev-Dev Mar 10, 2024
f4a9a35
add sketch on face e2e test
Irev-Dev Mar 11, 2024
0ecfc76
tweenCamToNegYAxis should respect reduced motion
Irev-Dev Mar 11, 2024
ce24dd9
initial sketch on face working with test
Irev-Dev Mar 11, 2024
f3aecad
remove temporary toolbar button and xState flow
Irev-Dev Mar 11, 2024
832123b
un-used vars
Irev-Dev Mar 11, 2024
4e6f3f8
snapshot test tweak
Irev-Dev Mar 11, 2024
c39b8eb
A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu)
github-actions[bot] Mar 11, 2024
49fd248
Merge remote-tracking branch 'origin' into kurt-selections-refactor
Irev-Dev Mar 12, 2024
6d53890
type tidy up
Irev-Dev Mar 12, 2024
4c0b1bf
Revert "A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu)"
Irev-Dev Mar 12, 2024
103e3b3
Revert "A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu)"
Irev-Dev Mar 12, 2024
3c49918
A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu)
github-actions[bot] Mar 12, 2024
8af2359
Merge branch 'main' into kurt-selections-refactor
Irev-Dev Mar 12, 2024
f05a121
Merge branch 'main' into kurt-selections-refactor
Irev-Dev Mar 12, 2024
951d23d
Merge branch 'main' into kurt-selections-refactor
Irev-Dev Mar 13, 2024
6fe7c6b
rename
Irev-Dev Mar 13, 2024
00f7cd6
sketch on sketch on sketch
Irev-Dev Mar 15, 2024
b4148ba
Merge remote-tracking branch 'origin' into kurt-selections-refactor
Irev-Dev Mar 15, 2024
53d4296
A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu)
github-actions[bot] Mar 15, 2024
84ef4e6
typo
Irev-Dev Mar 17, 2024
7acb149
Merge remote-tracking branch 'origin' into kurt-selections-refactor
Irev-Dev Mar 17, 2024
98693a4
Merge remote-tracking branch 'origin' into kurt-selections-refactor
Irev-Dev Mar 17, 2024
663940a
startSketchOn Endcaps
Irev-Dev Mar 17, 2024
93f7ff6
clear selections for entity_ids that are not recognised
Irev-Dev Mar 17, 2024
2e4206c
fix sketch on end cap of second order extrustion
Irev-Dev Mar 18, 2024
56694ef
tiny clean up
Irev-Dev Mar 18, 2024
d3d148c
fix sketch on close segment/face
Irev-Dev Mar 18, 2024
646b5c2
clean up 'lastCodeMirrorSelectionUpdatedFromScene'
Irev-Dev Mar 18, 2024
9129f9a
add code mode test for sketchOnExtrudedFace
Irev-Dev Mar 19, 2024
15dbf2c
make end cap selection more robust
Irev-Dev Mar 19, 2024
64a2f09
Merge branch 'main' into kurt-selections-refactor
Irev-Dev Mar 21, 2024
8953e6e
update js artifacts for extrudes
Irev-Dev Mar 21, 2024
4263f3c
update kcl docs
Irev-Dev Mar 21, 2024
14d284e
Merge branch 'main' into kurt-selections-refactor
Irev-Dev Mar 21, 2024
a11b5e8
clean up
Irev-Dev Mar 21, 2024
7f4638b
Merge branch 'main' into kurt-selections-refactor
Irev-Dev Mar 21, 2024
ee227ad
Merge branch 'main' into kurt-selections-refactor
Irev-Dev Mar 21, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/kcl/angleToMatchLengthX.md
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,8 @@ const part001 = startSketchOn('XY')
},
} |
{
// the face id the sketch is on
faceId: uuid,
// The id of the face.
id: uuid,
// The original sketch group id of the object we are sketching on.
Expand Down
2 changes: 2 additions & 0 deletions docs/kcl/angleToMatchLengthY.md
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,8 @@ const part001 = startSketchOn('XY')
},
} |
{
// the face id the sketch is on
faceId: uuid,
// The id of the face.
id: uuid,
// The original sketch group id of the object we are sketching on.
Expand Down
4 changes: 4 additions & 0 deletions docs/kcl/angledLine.md
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,8 @@ startSketchOn('XY')
},
} |
{
// the face id the sketch is on
faceId: uuid,
// The id of the face.
id: uuid,
// The original sketch group id of the object we are sketching on.
Expand Down Expand Up @@ -244,6 +246,8 @@ startSketchOn('XY')
},
} |
{
// the face id the sketch is on
faceId: uuid,
// The id of the face.
id: uuid,
// The original sketch group id of the object we are sketching on.
Expand Down
4 changes: 4 additions & 0 deletions docs/kcl/angledLineOfXLength.md
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,8 @@ startSketchOn('XZ')
},
} |
{
// the face id the sketch is on
faceId: uuid,
// The id of the face.
id: uuid,
// The original sketch group id of the object we are sketching on.
Expand Down Expand Up @@ -244,6 +246,8 @@ startSketchOn('XZ')
},
} |
{
// the face id the sketch is on
faceId: uuid,
// The id of the face.
id: uuid,
// The original sketch group id of the object we are sketching on.
Expand Down
4 changes: 4 additions & 0 deletions docs/kcl/angledLineOfYLength.md
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,8 @@ startSketchOn('YZ')
},
} |
{
// the face id the sketch is on
faceId: uuid,
// The id of the face.
id: uuid,
// The original sketch group id of the object we are sketching on.
Expand Down Expand Up @@ -245,6 +247,8 @@ startSketchOn('YZ')
},
} |
{
// the face id the sketch is on
faceId: uuid,
// The id of the face.
id: uuid,
// The original sketch group id of the object we are sketching on.
Expand Down
4 changes: 4 additions & 0 deletions docs/kcl/angledLineThatIntersects.md
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,8 @@ const part001 = startSketchOn('XY')
},
} |
{
// the face id the sketch is on
faceId: uuid,
// The id of the face.
id: uuid,
// The original sketch group id of the object we are sketching on.
Expand Down Expand Up @@ -250,6 +252,8 @@ const part001 = startSketchOn('XY')
},
} |
{
// the face id the sketch is on
faceId: uuid,
// The id of the face.
id: uuid,
// The original sketch group id of the object we are sketching on.
Expand Down
4 changes: 4 additions & 0 deletions docs/kcl/angledLineToX.md
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,8 @@ startSketchOn('XY')
},
} |
{
// the face id the sketch is on
faceId: uuid,
// The id of the face.
id: uuid,
// The original sketch group id of the object we are sketching on.
Expand Down Expand Up @@ -244,6 +246,8 @@ startSketchOn('XY')
},
} |
{
// the face id the sketch is on
faceId: uuid,
// The id of the face.
id: uuid,
// The original sketch group id of the object we are sketching on.
Expand Down
4 changes: 4 additions & 0 deletions docs/kcl/angledLineToY.md
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,8 @@ startSketchOn('XY')
},
} |
{
// the face id the sketch is on
faceId: uuid,
// The id of the face.
id: uuid,
// The original sketch group id of the object we are sketching on.
Expand Down Expand Up @@ -243,6 +245,8 @@ startSketchOn('XY')
},
} |
{
// the face id the sketch is on
faceId: uuid,
// The id of the face.
id: uuid,
// The original sketch group id of the object we are sketching on.
Expand Down
4 changes: 4 additions & 0 deletions docs/kcl/arc.md
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,8 @@ startSketchOn('-YZ')
},
} |
{
// the face id the sketch is on
faceId: uuid,
// The id of the face.
id: uuid,
// The original sketch group id of the object we are sketching on.
Expand Down Expand Up @@ -254,6 +256,8 @@ startSketchOn('-YZ')
},
} |
{
// the face id the sketch is on
faceId: uuid,
// The id of the face.
id: uuid,
// The original sketch group id of the object we are sketching on.
Expand Down
4 changes: 4 additions & 0 deletions docs/kcl/bezierCurve.md
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,8 @@ startSketchOn('XY')
},
} |
{
// the face id the sketch is on
faceId: uuid,
// The id of the face.
id: uuid,
// The original sketch group id of the object we are sketching on.
Expand Down Expand Up @@ -247,6 +249,8 @@ startSketchOn('XY')
},
} |
{
// the face id the sketch is on
faceId: uuid,
// The id of the face.
id: uuid,
// The original sketch group id of the object we are sketching on.
Expand Down
6 changes: 6 additions & 0 deletions docs/kcl/circle.md
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,8 @@ const rectangle = startSketchOn('XY')
},
} |
{
// the face id the sketch is on
faceId: uuid,
// The id of the face.
id: uuid,
// The original sketch group id of the object we are sketching on.
Expand Down Expand Up @@ -135,6 +137,8 @@ const rectangle = startSketchOn('XY')
},
} |
{
// the face id the sketch is on
faceId: uuid,
// The id of the face.
id: uuid,
// The original sketch group id of the object we are sketching on.
Expand Down Expand Up @@ -302,6 +306,8 @@ const rectangle = startSketchOn('XY')
},
} |
{
// the face id the sketch is on
faceId: uuid,
// The id of the face.
id: uuid,
// The original sketch group id of the object we are sketching on.
Expand Down
4 changes: 4 additions & 0 deletions docs/kcl/close.md
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,8 @@ startSketchOn('YZ')
},
} |
{
// the face id the sketch is on
faceId: uuid,
// The id of the face.
id: uuid,
// The original sketch group id of the object we are sketching on.
Expand Down Expand Up @@ -240,6 +242,8 @@ startSketchOn('YZ')
},
} |
{
// the face id the sketch is on
faceId: uuid,
// The id of the face.
id: uuid,
// The original sketch group id of the object we are sketching on.
Expand Down
2 changes: 2 additions & 0 deletions docs/kcl/extrude.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,8 @@ startSketchOn('XY')
},
} |
{
// the face id the sketch is on
faceId: uuid,
// The id of the face.
id: uuid,
// The original sketch group id of the object we are sketching on.
Expand Down
6 changes: 6 additions & 0 deletions docs/kcl/hole.md
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,8 @@ const square = startSketchOn('XY')
},
} |
{
// the face id the sketch is on
faceId: uuid,
// The id of the face.
id: uuid,
// The original sketch group id of the object we are sketching on.
Expand Down Expand Up @@ -236,6 +238,8 @@ const square = startSketchOn('XY')
},
} |
{
// the face id the sketch is on
faceId: uuid,
// The id of the face.
id: uuid,
// The original sketch group id of the object we are sketching on.
Expand Down Expand Up @@ -403,6 +407,8 @@ const square = startSketchOn('XY')
},
} |
{
// the face id the sketch is on
faceId: uuid,
// The id of the face.
id: uuid,
// The original sketch group id of the object we are sketching on.
Expand Down
2 changes: 2 additions & 0 deletions docs/kcl/lastSegX.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,8 @@ startSketchOn("YZ")
},
} |
{
// the face id the sketch is on
faceId: uuid,
// The id of the face.
id: uuid,
// The original sketch group id of the object we are sketching on.
Expand Down
2 changes: 2 additions & 0 deletions docs/kcl/lastSegY.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,8 @@ startSketchOn("YZ")
},
} |
{
// the face id the sketch is on
faceId: uuid,
// The id of the face.
id: uuid,
// The original sketch group id of the object we are sketching on.
Expand Down
4 changes: 4 additions & 0 deletions docs/kcl/line.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,8 @@ startSketchOn('-XY')
},
} |
{
// the face id the sketch is on
faceId: uuid,
// The id of the face.
id: uuid,
// The original sketch group id of the object we are sketching on.
Expand Down Expand Up @@ -234,6 +236,8 @@ startSketchOn('-XY')
},
} |
{
// the face id the sketch is on
faceId: uuid,
// The id of the face.
id: uuid,
// The original sketch group id of the object we are sketching on.
Expand Down
4 changes: 4 additions & 0 deletions docs/kcl/lineTo.md
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,8 @@ const part = rectShape([0, 0], 20, 20)
},
} |
{
// the face id the sketch is on
faceId: uuid,
// The id of the face.
id: uuid,
// The original sketch group id of the object we are sketching on.
Expand Down Expand Up @@ -240,6 +242,8 @@ const part = rectShape([0, 0], 20, 20)
},
} |
{
// the face id the sketch is on
faceId: uuid,
// The id of the face.
id: uuid,
// The original sketch group id of the object we are sketching on.
Expand Down
2 changes: 2 additions & 0 deletions docs/kcl/patternCircular2d.md
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,8 @@ const part = startSketchOn('XY')
},
} |
{
// the face id the sketch is on
faceId: uuid,
// The id of the face.
id: uuid,
// The original sketch group id of the object we are sketching on.
Expand Down
2 changes: 2 additions & 0 deletions docs/kcl/patternLinear2d.md
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,8 @@ const part = startSketchOn('XY')
},
} |
{
// the face id the sketch is on
faceId: uuid,
// The id of the face.
id: uuid,
// The original sketch group id of the object we are sketching on.
Expand Down
2 changes: 2 additions & 0 deletions docs/kcl/segAng.md
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,8 @@ const part001 = startSketchOn('XY')
},
} |
{
// the face id the sketch is on
faceId: uuid,
// The id of the face.
id: uuid,
// The original sketch group id of the object we are sketching on.
Expand Down
2 changes: 2 additions & 0 deletions docs/kcl/segEndX.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,8 @@ startSketchOn("YZ")
},
} |
{
// the face id the sketch is on
faceId: uuid,
// The id of the face.
id: uuid,
// The original sketch group id of the object we are sketching on.
Expand Down
2 changes: 2 additions & 0 deletions docs/kcl/segEndY.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,8 @@ startSketchOn("YZ")
},
} |
{
// the face id the sketch is on
faceId: uuid,
// The id of the face.
id: uuid,
// The original sketch group id of the object we are sketching on.
Expand Down
2 changes: 2 additions & 0 deletions docs/kcl/segLen.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,8 @@ startSketchOn("YZ")
},
} |
{
// the face id the sketch is on
faceId: uuid,
// The id of the face.
id: uuid,
// The original sketch group id of the object we are sketching on.
Expand Down
4 changes: 4 additions & 0 deletions docs/kcl/startProfileAt.md
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,8 @@ startSketchOn('XY')
},
} |
{
// the face id the sketch is on
faceId: uuid,
// The id of the face.
id: uuid,
// The original sketch group id of the object we are sketching on.
Expand Down Expand Up @@ -128,6 +130,8 @@ startSketchOn('XY')
},
} |
{
// the face id the sketch is on
faceId: uuid,
// The id of the face.
id: uuid,
// The original sketch group id of the object we are sketching on.
Expand Down
2 changes: 2 additions & 0 deletions docs/kcl/startSketchAt.md
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,8 @@ startSketchAt([0, 0])
},
} |
{
// the face id the sketch is on
faceId: uuid,
// The id of the face.
id: uuid,
// The original sketch group id of the object we are sketching on.
Expand Down
2 changes: 2 additions & 0 deletions docs/kcl/startSketchOn.md
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,8 @@ string
},
} |
{
// the face id the sketch is on
faceId: uuid,
// The id of the face.
id: uuid,
// The original sketch group id of the object we are sketching on.
Expand Down
Loading
Loading