-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SketchOnFace UI #1664
Merged
Merged
SketchOnFace UI #1664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Irev-Dev
force-pushed
the
kurt-selections-refactor
branch
from
March 8, 2024 07:54
c835b51
to
fdcd9e4
Compare
… not orientation of instersection plane etc
This reverts commit 406fca4.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1664 +/- ##
==========================================
+ Coverage 85.53% 85.54% +0.01%
==========================================
Files 46 46
Lines 19312 19326 +14
==========================================
+ Hits 16519 16533 +14
Misses 2793 2793
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that the sketch on face stuff will have breaking changes in future, If you have access see: https://github.com/KittyCAD/engine/issues/1874
As we roll into features like SketchOnFace and fillets our ability to associate 3d features back to source code becomes much more important e.g. adding a tag in the correct place in the code so that we reference a face to sketch on or reference an edge to fillet. Because of this is was about time to give the selections some attention. Previous the way they were setup had a single code path for selecting either from the 3d scene, or placing your cursor directly in codemirror (because selections are just sourceRanges/cursor positions). The single code path seemed like a good idea since to made the code DRY, but it was dry spaghetti that callbacks spread all over the place
plus overhaul of selections
artifactMap
) should be cleared by default, and we should work to makes sure that entity get's into the artifact map. 93f7ff6lastCodeMirrorSelectionUpdatedFromScene
(646b5c2)optional
sketchEnginePathId
in xstate contextThings to ask Josh about
-- edit, the chat Josh and I had resulted in this, we're going to keep chatting about it.
Alignment of extrude walls
below)Things to bring up with Mike
highlight_set_entity
events don't come through for edit mode, they highlight in the stream, but no websocket message come's through, check what I'm calling edit mode on.solid3d_get_extrusion_face_info
returns an empty array for these extrusions (side note that the original extend_path id get associated with the end of the extrusion, I thought it should probably be the start so as to sit on the face where it was sketched)startSketchOn(part, 'START')
seems to be different from "END" (not sure what to do about this)Things to bring up with Jess
-- edit had a chat with Jess, edge ids on the sketch group should probably be done in collaboration with the grackle team since that migration is underway. Mock safe execution hacks are probably fine, I'll just leave a bunch of comments.
sketchGroup.on
doesn't quiet have the info I need, have to rummage around to cobble it together (vague point probably covered by some of the above).