Make tag last optional param everywhere

[iterion]

closes #1730

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
modeling-app	✅ Ready (Inspect)	Visit Preview	Mar 15, 2024 8:52pm

[jessfraz]

Awesome thanks for doing this lgtm when all tests pas cc @jgomez720 to update his samples everywhere and I can bump the cli after

[jgomez720]

Oh super cool. Just to make sure I'm understanding this right, this is changing the structure from

|> line({to: [5, 5], tag: 'mySuperNiceLine'}, %)

to

|> line([5, 5], %, 'mySuperNiceLine')

[iterion]

Yep, you got it! Anything that took an optional tag: "something" will change to the second format you gave where tag is always the optional last parameter.

[jessfraz]

why isnt cargo test running?

[jessfraz]

rebase on this once merged #1740

[Irev-Dev]

FYI found a regression with this.
#1747

Nice work though 👏

[Irev-Dev]

The bug I found was it adding the classic js object Object as a tag 😂

Screenshare.-.2024-03-17.5_18_52.PM.mp4

[iterion]

HA, of course I missed something! I even fixed a bug just like that one elsewhere. Thanks for the quick fix and explanation. I wonder if I can get some unit test coverage on that, the existing unit tests were invaluable in making this change.

[Irev-Dev]

Well I found it on my "sketchOnFace" branch after merging in main, because I did have extrude working back when it was my fake engine it's probably found some tag logic that hasn't been used in a long time. Probably means it was under tested before, but this might also be a timing thing that I happen to be working on sketchOnFace when this went through, so maybe less of a regression and more of a regression in my branch ya know.

I do have one e2e test for the sketch on face, I plan on adding more. I just added a add unit test for the extrusion codemod in my TODO list in the description.

[Irev-Dev]

SketchOnExtrudedFace unit test is in my branch now too

9129f9a

[iterion]

Fantastic, thanks @Irev-Dev!