Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tag changes followup #1747

Merged
merged 2 commits into from
Mar 17, 2024
Merged

tag changes followup #1747

merged 2 commits into from
Mar 17, 2024

Conversation

Irev-Dev
Copy link
Collaborator

related to #1739

Copy link

vercel bot commented Mar 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Mar 17, 2024 7:20am

function addTagWithTo(
argType: 'angleLength' | 'angleTo' | 'default' | 'length'
): addTagFn {
function addTag(): addTagFn {
Copy link
Collaborator Author

@Irev-Dev Irev-Dev Mar 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not very DRY as it's copy paste from giveSketchFnCallTag except one takes a source range and the other pathToNode.

@Irev-Dev Irev-Dev merged commit cefa6f8 into main Mar 17, 2024
13 checks passed
@Irev-Dev Irev-Dev deleted the kurt-tag-changes-followup branch March 17, 2024 07:24
@pierremtb pierremtb mentioned this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant