Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

segment refactor + Circle [WIP] #3695

Closed
wants to merge 50 commits into from
Closed

segment refactor + Circle [WIP] #3695

wants to merge 50 commits into from

Conversation

Irev-Dev
Copy link
Collaborator

@Irev-Dev Irev-Dev commented Aug 28, 2024

made redundant by #3859 and #3860

Because I'm doing some ractoring too, I'll like break this into two separate PRs and close this one when they're ready.


Remaining tasks

  • Draft circle looks funny
  • Cursor should be crosshair when circle tool is equipped
  • Console error when doing the second click for adding the circle Expected [..] to be a sketchGroup, but it wasn't.
  • Extra segment handle is appearing when it shouldn't
  • Fix sketch mode tear down weirdness
  • Disable line tool after rectangle or circle
  • Overlays [absX, absY, and radius]
  • Check line thickness and handles scale correctly with zoom
  • Check exiting out of the sketch after the first click but before the second doesn't do anything weird
  • fix error when dragging circle's circumference
  • Check three dot menu works for circle, (probably need to dump delete short term until multi-profile sketches)
  • Figure what's going on with the cargo tests
  • see if it's worth breaking refactors into separate PR

Tests

  • draft circle should look right (snapshot)
  • Can create a new sketch and put a circle on it.
  • Can edit an existing circle changing its center and radius
  • test for the overlay

Copy link

vercel bot commented Aug 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Sep 10, 2024 11:14am

Copy link

qa-wolf bot commented Aug 28, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@Irev-Dev Irev-Dev changed the title Circle [WIP] segment refactor + Circle [WIP] Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant