Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

segment refactor + Circle [WIP] #3695

Closed
wants to merge 50 commits into from
Closed

segment refactor + Circle [WIP] #3695

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
b7c71c0
xstate start
Irev-Dev Aug 19, 2024
acfa95f
basic circle edit working
Irev-Dev Aug 24, 2024
1988888
update is editing existing sketch
Irev-Dev Aug 24, 2024
c56c446
add circle segment to searches
Irev-Dev Aug 24, 2024
3409aa5
Merge remote-tracking branch 'origin' into kurt-circle
Irev-Dev Aug 27, 2024
22c8548
can use circle tool tip
Irev-Dev Aug 28, 2024
44e07ca
fix draft arc not being complete
Irev-Dev Aug 28, 2024
bfd92a6
remove extra segment handle
Irev-Dev Aug 28, 2024
8d912fa
make sure cursor is consistent with other tool tips
Irev-Dev Aug 28, 2024
3799605
fix weird tear down issue
Irev-Dev Aug 28, 2024
c6577a5
remove error when circle has second click
Irev-Dev Aug 28, 2024
3e4316b
Merge remote-tracking branch 'origin' into kurt-circle
Irev-Dev Aug 28, 2024
0d5a8ae
change start end angle for draft circle so that it animates from the …
Irev-Dev Aug 29, 2024
a1f8ac4
Merge remote-tracking branch 'origin' into kurt-circle
Irev-Dev Aug 29, 2024
706af59
Merge remote-tracking branch 'origin' into kurt-circle
Irev-Dev Sep 2, 2024
72e522d
change circle args
Irev-Dev Sep 4, 2024
94b0510
big refactor of var values for astMods
Irev-Dev Sep 6, 2024
abb8b95
Merge remote-tracking branch 'origin' into kurt-circle
Irev-Dev Sep 6, 2024
6753a9e
make lint happy
Irev-Dev Sep 7, 2024
998b194
fix unit tests
Irev-Dev Sep 9, 2024
5592185
Merge remote-tracking branch 'origin' into kurt-circle
Irev-Dev Sep 9, 2024
59284ff
rely a little less on arbitary indexs
Irev-Dev Sep 9, 2024
57a460f
update samples
Irev-Dev Sep 9, 2024
a59de4e
hopefully fix e2e tests
Irev-Dev Sep 9, 2024
b3c4aec
try increas playwright timeout
Irev-Dev Sep 9, 2024
48d347b
add e2e tests
Irev-Dev Sep 9, 2024
85abcde
make sure behaviour is sane betwen center and radius clicks
Irev-Dev Sep 9, 2024
466511a
A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu-latest)
github-actions[bot] Sep 9, 2024
840e75e
fix dragging circle circumference error
Irev-Dev Sep 9, 2024
9d6a097
A snapshot a day keeps the bugs away! 📷🐛 (OS: windows-latest)
github-actions[bot] Sep 9, 2024
b55652f
fix circle line thickness and handles scale correctly on zoom
Irev-Dev Sep 9, 2024
994f71b
make clippy happy
Irev-Dev Sep 9, 2024
a1dd884
stdlib docs update
Irev-Dev Sep 9, 2024
e794c5b
Update some circle function calls and twenty twenty stuff
Irev-Dev Sep 9, 2024
7ab9b3e
Merge remote-tracking branch 'origin' into kurt-circle
Irev-Dev Sep 9, 2024
15871e6
cargo fmt
Irev-Dev Sep 9, 2024
63dea71
some renames
Irev-Dev Sep 9, 2024
bb265ca
few more minor renames
Irev-Dev Sep 9, 2024
4219a2c
more minor clean up renaming
Irev-Dev Sep 9, 2024
99ffc82
change types that that effected a lot of places
Irev-Dev Sep 9, 2024
25080e9
clean up create call back double function stuff
Irev-Dev Sep 9, 2024
a6aff87
more types clean up
Irev-Dev Sep 9, 2024
28a6319
more clean up
Irev-Dev Sep 9, 2024
266c601
Merge remote-tracking branch 'origin' into kurt-circle
Irev-Dev Sep 10, 2024
0abe4c4
some xstate v5 stuff that got missed from merge with main
Irev-Dev Sep 10, 2024
04e82bf
comments and naming tweaks
Irev-Dev Sep 10, 2024
9fafc90
remove surplus | 'radius's
Irev-Dev Sep 10, 2024
93d3df4
more renaming
Irev-Dev Sep 10, 2024
fa580d4
clean up by grouping segment labels
Irev-Dev Sep 10, 2024
c26709c
Merge remote-tracking branch 'origin' into kurt-circle
Irev-Dev Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/playwright.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, windows-latest, macos-14]
timeout-minutes: 40
timeout-minutes: 60
runs-on: ${{ matrix.os }}
needs: check-rust-changes
steps:
Expand Down
40 changes: 40 additions & 0 deletions docs/kcl/angleToMatchLengthX.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,6 +270,26 @@ const extrusion = extrude(5, sketch001)
to: [number, number],
type: "TangentialArc",
} |
{
// arc's direction
ccw: bool,
// the arc's center
center: [number, number],
// The from point.
from: [number, number],
// the arc's radius
radius: number,
// The tag of the path.
tag: {
digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
end: number,
start: number,
value: string,
},
// The to point.
to: [number, number],
type: "Circle",
} |
{
// The from point.
from: [number, number],
Expand Down Expand Up @@ -479,6 +499,26 @@ const extrusion = extrude(5, sketch001)
to: [number, number],
type: "TangentialArc",
} |
{
// arc's direction
ccw: bool,
// the arc's center
center: [number, number],
// The from point.
from: [number, number],
// the arc's radius
radius: number,
// The tag of the path.
tag: {
digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
end: number,
start: number,
value: string,
},
// The to point.
to: [number, number],
type: "Circle",
} |
{
// The from point.
from: [number, number],
Expand Down
40 changes: 40 additions & 0 deletions docs/kcl/angleToMatchLengthY.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,6 +274,26 @@ const extrusion = extrude(5, sketch001)
to: [number, number],
type: "TangentialArc",
} |
{
// arc's direction
ccw: bool,
// the arc's center
center: [number, number],
// The from point.
from: [number, number],
// the arc's radius
radius: number,
// The tag of the path.
tag: {
digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
end: number,
start: number,
value: string,
},
// The to point.
to: [number, number],
type: "Circle",
} |
{
// The from point.
from: [number, number],
Expand Down Expand Up @@ -483,6 +503,26 @@ const extrusion = extrude(5, sketch001)
to: [number, number],
type: "TangentialArc",
} |
{
// arc's direction
ccw: bool,
// the arc's center
center: [number, number],
// The from point.
from: [number, number],
// the arc's radius
radius: number,
// The tag of the path.
tag: {
digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
end: number,
start: number,
value: string,
},
// The to point.
to: [number, number],
type: "Circle",
} |
{
// The from point.
from: [number, number],
Expand Down
80 changes: 80 additions & 0 deletions docs/kcl/angledLine.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,26 @@ const example = extrude(10, exampleSketch)
to: [number, number],
type: "TangentialArc",
} |
{
// arc's direction
ccw: bool,
// the arc's center
center: [number, number],
// The from point.
from: [number, number],
// the arc's radius
radius: number,
// The tag of the path.
tag: {
digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
end: number,
start: number,
value: string,
},
// The to point.
to: [number, number],
type: "Circle",
} |
{
// The from point.
from: [number, number],
Expand Down Expand Up @@ -398,6 +418,26 @@ const example = extrude(10, exampleSketch)
to: [number, number],
type: "TangentialArc",
} |
{
// arc's direction
ccw: bool,
// the arc's center
center: [number, number],
// The from point.
from: [number, number],
// the arc's radius
radius: number,
// The tag of the path.
tag: {
digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
end: number,
start: number,
value: string,
},
// The to point.
to: [number, number],
type: "Circle",
} |
{
// The from point.
from: [number, number],
Expand Down Expand Up @@ -609,6 +649,26 @@ const example = extrude(10, exampleSketch)
to: [number, number],
type: "TangentialArc",
} |
{
// arc's direction
ccw: bool,
// the arc's center
center: [number, number],
// The from point.
from: [number, number],
// the arc's radius
radius: number,
// The tag of the path.
tag: {
digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
end: number,
start: number,
value: string,
},
// The to point.
to: [number, number],
type: "Circle",
} |
{
// The from point.
from: [number, number],
Expand Down Expand Up @@ -818,6 +878,26 @@ const example = extrude(10, exampleSketch)
to: [number, number],
type: "TangentialArc",
} |
{
// arc's direction
ccw: bool,
// the arc's center
center: [number, number],
// The from point.
from: [number, number],
// the arc's radius
radius: number,
// The tag of the path.
tag: {
digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
end: number,
start: number,
value: string,
},
// The to point.
to: [number, number],
type: "Circle",
} |
{
// The from point.
from: [number, number],
Expand Down
80 changes: 80 additions & 0 deletions docs/kcl/angledLineOfXLength.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,26 @@ const extrusion = extrude(10, sketch001)
to: [number, number],
type: "TangentialArc",
} |
{
// arc's direction
ccw: bool,
// the arc's center
center: [number, number],
// The from point.
from: [number, number],
// the arc's radius
radius: number,
// The tag of the path.
tag: {
digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
end: number,
start: number,
value: string,
},
// The to point.
to: [number, number],
type: "Circle",
} |
{
// The from point.
from: [number, number],
Expand Down Expand Up @@ -397,6 +417,26 @@ const extrusion = extrude(10, sketch001)
to: [number, number],
type: "TangentialArc",
} |
{
// arc's direction
ccw: bool,
// the arc's center
center: [number, number],
// The from point.
from: [number, number],
// the arc's radius
radius: number,
// The tag of the path.
tag: {
digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
end: number,
start: number,
value: string,
},
// The to point.
to: [number, number],
type: "Circle",
} |
{
// The from point.
from: [number, number],
Expand Down Expand Up @@ -608,6 +648,26 @@ const extrusion = extrude(10, sketch001)
to: [number, number],
type: "TangentialArc",
} |
{
// arc's direction
ccw: bool,
// the arc's center
center: [number, number],
// The from point.
from: [number, number],
// the arc's radius
radius: number,
// The tag of the path.
tag: {
digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
end: number,
start: number,
value: string,
},
// The to point.
to: [number, number],
type: "Circle",
} |
{
// The from point.
from: [number, number],
Expand Down Expand Up @@ -817,6 +877,26 @@ const extrusion = extrude(10, sketch001)
to: [number, number],
type: "TangentialArc",
} |
{
// arc's direction
ccw: bool,
// the arc's center
center: [number, number],
// The from point.
from: [number, number],
// the arc's radius
radius: number,
// The tag of the path.
tag: {
digest: [number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number, number],
end: number,
start: number,
value: string,
},
// The to point.
to: [number, number],
type: "Circle",
} |
{
// The from point.
from: [number, number],
Expand Down
Loading
Loading