fix: only count something as a directory if it has children #4556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lf94
reviewed
Nov 27, 2024
Comment on lines
+311
to
+313
| if (entry.children !== null) { | ||
| count += 1 | ||
| } |
There was a problem hiding this comment.
I would have done if (!entry.children) continue; but this works too :P
|
Are the test failures expected? They don't seem related to my changes, but I also can't run those failing tests locally. |
|
Merged in #4595. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4515
Every entry was being counted as a directory on the ProjectCard when it should have only been counting entries with
childrenWith this file tree:
before:
after: