fix: only count something as a directory if it has children

[jtran]

Replaces #4556. Working around CI limitation.
Closes #4515.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
modeling-app	✅ Ready (Inspect)	Visit Preview	Dec 2, 2024 8:01pm

[qa-wolf]

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

[TomPridham]

I also just pushed a change to my branch that updates the e2e tests in the file-tree-spec since they were expecting the old behavior

[TomPridham]

Oh, so, this line is never resolving because the span with that test id doesn't get rendered if there are 0 folders
https://github.com/KittyCAD/modeling-app/blob/main/e2e/playwright/fixtures/homePageFixture.ts#L67

[TomPridham]

There aren't currently any tests actually using the folder count, so deleting it would be an option. I did push another fix that I think would fix it. I can't actually run the e2e tests based on the info in the readme afaik

[jtran]

If it doesn't work, I think removing the folder count from the helper and only using it where we explicitly want to assert the value is a good option.

[TomPridham]

Okay, I removed the folder count. Hopefully that's the last thing

[pierremtb]

Thanks @TomPridham and @jtran!