Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Filter Development #68
base: master
Are you sure you want to change the base?
[RFC] Filter Development #68
Changes from all commits
de3f298
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[General]
Filter
should be a class template. At a minimum, it should be assumed thatFilter
takes in some kind of scalar type (e.g.,int
,float
, etc.). Abstracting further, it could take in containers containing scalars (e.g.,Eigen::Vector<float, ...>
,std::array<double, ...>
,std::vector<int>
, etc.). Your current implementation only acceptsEigen::Vector3f
data, which is not always the desired type.For the scalar case, this might be
Then, the data types inside would be
Scalar
instead ofEigen::Vector3f
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[General] Same comment as in
Filter
. This should probably be a class template.Note that, for this class, both the definition and implementation would have to live in the header file if you make this a class template. See here for more information.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[General] Per this ISO C++ Standard item, you should use an initializer list here instead of assignment.