TS-1746: ApprovalStatus as a string #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to JIRA ticket
https://hackney.atlassian.net/browse/TS-1746
Describe this PR
What is the problem we're trying to solve
We need for ApprovalStatus to be set as a string in the Housing Search world to avoid de/serialisation issues and receive it as a string (as opposed to the current integer) in the Housing Search API response
What changes have we introduced
Changed type for ApprovalStatus, deleted unnecessary enum and references to it
Checklist
Follow up actions after merging PR
Update Listener and API.