Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS-1746: ApprovalStatus as a string #87

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

martapederiva
Copy link
Contributor

Link to JIRA ticket

https://hackney.atlassian.net/browse/TS-1746

Describe this PR

What is the problem we're trying to solve

We need for ApprovalStatus to be set as a string in the Housing Search world to avoid de/serialisation issues and receive it as a string (as opposed to the current integer) in the Housing Search API response

What changes have we introduced

Changed type for ApprovalStatus, deleted unnecessary enum and references to it

Checklist

  • Added end-to-end (i.e. integration) tests where necessary e.g to test complete functionality of a newly added feature
  • Added tests to cover all new production code
  • Added comments to the README or updated relevant documentation (add link to documentation), where necessary.
  • Checked all code for possible refactoring
  • [ X] Code pipeline builds correctly

Follow up actions after merging PR

Update Listener and API.

@martapederiva martapederiva requested a review from a team as a code owner October 25, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants