Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS-1746: ApprovalStatus as a string #87

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Hackney.Shared.HousingSearch/Domain/Asset/Contract.cs
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
using Hackney.Shared.HousingSearch.Domain.Contract;
using Hackney.Shared.HousingSearch.Domain.Enums;
using System;
using System.Collections.Generic;

Expand All @@ -15,7 +14,7 @@ public class Contract
public DateTime? EndDate { get; set; }
public string EndReason { get; set; }
public bool? IsApproved { get; set; }
public ApprovalStatus ApprovalStatus { get; set; }
public string ApprovalStatus { get; set; }
public string ApprovalStatusReason { get; set; }
public bool? IsActive { get; set; }
public IEnumerable<Charges> Charges { get; set; }
Expand Down
3 changes: 1 addition & 2 deletions Hackney.Shared.HousingSearch/Domain/Contract/Contract.cs
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
using Hackney.Shared.HousingSearch.Gateways.Models.Contract;
using Hackney.Shared.HousingSearch.Domain.Enums;
using System;
using System.Collections.Generic;

Expand All @@ -15,7 +14,7 @@ public class Contract
public DateTime? EndDate { get; set; }
public string EndReason { get; set; }
public bool? IsApproved { get; set; }
public ApprovalStatus ApprovalStatus { get; set; }
public string ApprovalStatus { get; set; }
public string ApprovalStatusReason { get; set; }
public bool? IsActive { get; set; }
public IEnumerable<QueryableCharges> Charges { get; set; }
Expand Down
12 changes: 0 additions & 12 deletions Hackney.Shared.HousingSearch/Domain/Enums/ApprovalStatus.cs

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
using System;
using Hackney.Shared.HousingSearch.Gateways.Models.Contract;
using Hackney.Shared.HousingSearch.Domain.Enums;
using Nest;
using System.Collections.Generic;

Expand All @@ -17,7 +16,7 @@ public class QueryableAssetContract
public DateTime? EndDate { get; set; }
public string EndReason { get; set; }
public bool? IsApproved { get; set; }
public ApprovalStatus ApprovalStatus { get; set; }
public string ApprovalStatus { get; set; }
public string ApprovalStatusReason { get; set; }
public bool? IsActive { get; set; }
public IEnumerable<QueryableCharges> Charges { get; set; }
Expand Down
Loading