Feature to ingest template images from surveys for O4 galaxies #124
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows for automatic ingestion of template images from SDSS (and soon, PS1 and DECam) for galaxies that are observed by LCO during LVK O4. Three new files--
ingesttemplates.py
,runo4templateingest.py
, andrungwgalaxydiff.py
--handle the template image ingestion, PSF generation, cosmic ray removal, and background subtraction. Each can be run from the command line by passing a target ID and filter using the--targetid
and-f
flags. To get the template ingestion to work without having LCO images obtained beforehand, I had to rewrite those existing stages to accept either a list of files OR both a target ID and filter. Currently I've tested this for SDSS ingestion and reduction, and once the PS1 and DECam ingestion features are merged those can be tested too.During the process I also discovered what I think is a bug with the pipeline installation instructions. Step 9 says to
export LCOSNDIR=/your/data/directory
but when ingesting reference images this path didn't work and threw an error. I had to setLCOSNDIR=/your/data/
instead to get the ingestion to work. I'm not sure if this is a bug that's specific to reference image ingestion or if it's a bigger issue, but I've left it alone in the code for now.