Make compile -Wall/-Werror proof #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tepperly do you want us to take over the remaining work needed to merge this PR? |
cnpetra
reviewed
Sep 8, 2023
CMakeLists.txt
Outdated
| @@ -1,11 +1,12 @@ | |||
| cmake_minimum_required (VERSION 3.18) | |||
|
|
|||
| set(CMAKE_CXX_STANDARD 14) | |||
| set(CMAKE_CXX_STANDARD 17) | |||
There was a problem hiding this comment.
@tepperly To minimize disruptions on our users, I would like to keep this at 14. Would cmake-ing HiOp with -DCMAKE_CXX_STANDARD=17 work on your end?
Merged
nychiang
force-pushed
the
feature/headers-wall-werror-proof
branch
2 times, most recently
from
faf62b7 to
55413e7
Compare
* try to fix the CI tests on github * try to fix the CI tests on github * add deepcheck * pass quartz CI * build on lassen * remove some unused var * fix PNNL CI v1 * try to fix ginkgo issue
nychiang
force-pushed
the
feature/headers-wall-werror-proof
branch
from
55413e7 to
43c872d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NY_202309:
This PR replaces PR #646
CLOSE #646