try to fix the CI tests on github #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tepperly @cnpetra Please feel free to review the changes. It works fine on LLNL CI, pass all the tests with/without CUDA, RAJA, OPENMP, MPI. However, right now it cannot pass PNNL CI due to a narrowing conversion when Ginkgo is used. I have opened a new issue for that, and I will pin @pelesh for further investigation. |
fritzgoebel
approved these changes
Sep 5, 2023
cnpetra
approved these changes
Sep 6, 2023
|
in interest of time I am merging this... |
nychiang
added a commit
that referenced
this pull request
Sep 29, 2023
* try to fix the CI tests on github * try to fix the CI tests on github * add deepcheck * pass quartz CI * build on lassen * remove some unused var * fix PNNL CI v1 * try to fix ginkgo issue
nychiang
added a commit
that referenced
this pull request
Sep 29, 2023
* try to fix the CI tests on github * try to fix the CI tests on github * add deepcheck * pass quartz CI * build on lassen * remove some unused var * fix PNNL CI v1 * try to fix ginkgo issue
cnpetra
pushed a commit
that referenced
this pull request
Oct 2, 2023
* Try resolving issues discovered with -Wall -Werror * Remove unused private data members, resolve overridden virtual functions * try to fix the CI tests on github (#654) * try to fix the CI tests on github * try to fix the CI tests on github * add deepcheck * pass quartz CI * build on lassen * remove some unused var * fix PNNL CI v1 * try to fix ginkgo issue * create branch, switch to cpp14 (#661) * rebase and fix issues introduced by rebase --------- Co-authored-by: Nai-Yuan Chiang <[email protected]> Co-authored-by: nychiang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some other files that need to be fixed in order to pass the CI tests.
remove some [[maybe_unused]] suggested by Tom
based on #653
@tepperly