Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relaxation Runge-Kutta Methods #298

Merged
merged 123 commits into from
Jul 17, 2023
Merged

Relaxation Runge-Kutta Methods #298

merged 123 commits into from
Jul 17, 2023

Conversation

gardner48
Copy link
Member

Add support for explicit, implicit, and IMEX relaxation Runge-Kutta methods in ERKStep and ARKStep

@gardner48
Copy link
Member Author

I think I've address most of the PR comments and have left unresolved those that might need further discussion.

@gardner48
Copy link
Member Author

I've addressed the remaining comments, this should be ready for another review pass.

Copy link
Collaborator

@drreynolds drreynolds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested a fix for ark_pendulum.cpp to improve the output (as noted in the accompanying "answers" PR). With this suggestion, I'm happy with both PRs.

examples/arkode/CXX_serial/ark_pendulum.cpp Outdated Show resolved Hide resolved
drreynolds
drreynolds previously approved these changes Jul 14, 2023
@balos1 balos1 merged commit cd0d062 into develop Jul 17, 2023
14 checks passed
@balos1 balos1 deleted the feature/relax branch July 17, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants