Feature/sunmpicomm #370
Merged
Feature/sunmpicomm #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
balos1
commented
Nov 7, 2023
•
balos1
commented
- Addresses nvgetcommunicator returning pointer to MPI_Comm leads to complicated designs. #275
- Requires MPI to be linked to SUNDIALS core if its enabled thus forcing us to drop support for the all-in-one MPI and no MPI build. Instead users would have to separately build and install with and without MPI.
Co-authored-by: Daniel R. Reynolds <[email protected]>
Added Fortran support for the LAPACK dense SUNLinearSolver implementation. --------- Co-authored-by: Daniel R. Reynolds <[email protected]>
Additional embedded explicit Runge--Kutta methods to ARKODE. --------- Co-authored-by: Steven Roberts <[email protected]> Co-authored-by: David J. Gardner <[email protected]>
…recated-code-types
|
All current comments have been addressed and all tests are passing. |
gardner48
requested changes
Nov 28, 2023
Co-authored-by: David Gardner <[email protected]>
gardner48
approved these changes
Nov 28, 2023
drreynolds
reviewed
Nov 28, 2023
drreynolds
reviewed
Nov 28, 2023
drreynolds
reviewed
Nov 28, 2023
| @@ -224,14 +224,13 @@ void N_VSpace_Trilinos(N_Vector x, sunindextype *lrw, sunindextype *liw) | |||
| /* | |||
| * MPI communicator accessor | |||
| */ | |||
| void *N_VGetCommunicator_Trilinos(N_Vector x) | |||
| MPI_Comm N_VGetCommunicator_Trilinos(N_Vector x) | |||
There was a problem hiding this comment.
Trilinos can be built without MPI, so should this be SUNComm instead, or do we require that we only link against MPI-enabled Trilinos installations?
There was a problem hiding this comment.
I believe our interfaces will work with Trilinos configured with MPI enabled/disabled so this one should be an SUNComm.
gardner48
added a commit
that referenced
this pull request
Dec 18, 2023
Addresses #275. Requires MPI to be linked to SUNDIALS core if it is enabled thus all-in-one MPI and non-MPI builds are no longer supported. Instead user will have to separately build and install with and without MPI. --------- Co-authored-by: Daniel R. Reynolds <[email protected]> Co-authored-by: Steven Roberts <[email protected]> Co-authored-by: David J. Gardner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.