Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue/627/testskypixelcoords: New notebook to test coordinate system effects with instructions to use example data #629

Merged
merged 61 commits into from
Jul 19, 2024
Merged

issue/627/testskypixelcoords: New notebook to test coordinate system effects with instructions to use example data #629

merged 61 commits into from
Jul 19, 2024

Commits on Jul 15, 2024

  1. feat: Add coordinate_system parameter to compute_tangential_and_cross… 

    …_components and _compute_lensing_angles functions
    @caioolivv
    caioolivv committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    ec3c8fc View commit details
    Browse the repository at this point in the history

  2. Update documentation to account for new coordinate_system option

    @caioolivv
    caioolivv committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    86972dc View commit details
    Browse the repository at this point in the history

  3. feat: Add coordinate_system conversion test to test_compute_lensing_a… 

    …ngles_flatsky function
    @caioolivv
    caioolivv committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    10a6236 View commit details
    Browse the repository at this point in the history

  4. Add coordinate_system conversion test to test_compute_lensing_angles_… 

    …astropy function and fix bug in coordinate system conversion bug in compute_lensing_angles_astropy
    @caioolivv
    caioolivv committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    a2d4989 View commit details
    Browse the repository at this point in the history

  5. Set coordinate_system option during creation of GalaxyCluster object

    @caioolivv
    caioolivv committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    fd3169b View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. adding a new notebook and data

    @ts485
    ts485 committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    9e8676f View commit details
    Browse the repository at this point in the history

  2. test

    @ts485
    ts485 committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    3205ff2 View commit details
    Browse the repository at this point in the history

  3. Merge main into issue/613/ellipticity_coord_system

    @caioolivv
    caioolivv committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    ca81e1f View commit details
    Browse the repository at this point in the history

  4. new notebook to test coordinate systems and shear measurements

    @ts485
    ts485 committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    a215927 View commit details
    Browse the repository at this point in the history

  5. Removed debuggin print in test_dataops.py

    @caioolivv
    caioolivv committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    7cae62e View commit details
    Browse the repository at this point in the history

  6. editing README for the data availability

    @ts485
    ts485 committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    e85db0b View commit details
    Browse the repository at this point in the history

  7. moved tomomi's notebook to examples

    @cavestruz
    cavestruz committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    44422ec View commit details
    Browse the repository at this point in the history

  8. added prelude to Tomomi's notebook

    @cavestruz
    cavestruz committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    24a1470 View commit details
    Browse the repository at this point in the history

  9. Fixed typo and set default coordinate_system to "pixel"

    @caioolivv
    caioolivv committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    a6e995a View commit details
    Browse the repository at this point in the history

  10. Added option to choose coordinate system for generated mock catalog

    @caioolivv
    caioolivv committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    c950229 View commit details
    Browse the repository at this point in the history

  11. Added ellipticity coordinate system conversion tests to test_galaxycl… 

    …uster.py and test_mockdata.py
    @caioolivv
    caioolivv committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    9bdc6cd View commit details
    Browse the repository at this point in the history

  12. Added documentation to other test cases in Tomomi's notebook. Still n… 

    …eed to incorporate Caio's added functionality for sky vs. pixel coordinates in CLMM
    @cavestruz
    cavestruz committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    b1245d5 View commit details
    Browse the repository at this point in the history

  13. Fixed formatting

    @caioolivv
    caioolivv committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    479f74a View commit details
    Browse the repository at this point in the history

  14. starting to work through and document example of lensing signal calcu… 

    …lation of HSCY3 cluster without CLMM, but need to change colossus dependency because it is not easy to install on NERSC
    @cavestruz
    cavestruz committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    134e65d View commit details
    Browse the repository at this point in the history

  15. Finished baseline documentation, including changing colossus cosmolog… 

    …y dependency in notebook to the astropy one so this is easier to run on NERSC
    @cavestruz
    cavestruz committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    b335218 View commit details
    Browse the repository at this point in the history

  16. minor change to clarify sections of notebook

    @cavestruz
    cavestruz committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    0faa78e View commit details
    Browse the repository at this point in the history

  17. added kwargs to GalaxyCluster instance definition in preparation for … 

    …re-installing latest CLMM with Caio's added coordinate_system kwargs
    @cavestruz
    cavestruz committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    1452a3a View commit details
    Browse the repository at this point in the history

  18. Updated logic for lensing angle conversion between coordinate systems… 

    … in _compute_lensing_angles_flatsky and updated tests
    @caioolivv
    caioolivv committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    4a1faa6 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. Revert "Updated logic for lensing angle conversion between coordinate… 

    … systems in _compute_lensing_angles_flatsky and updated tests"

This reverts commit 4a1faa6.
    @caioolivv
    caioolivv committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    5493cce View commit details
    Browse the repository at this point in the history

  2. Added coordinate_system validation and extra tests

    @caioolivv
    caioolivv committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    2718680 View commit details
    Browse the repository at this point in the history

  3. Changed example notebook to document new coordinate_system option

    @caioolivv
    caioolivv committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    d36a771 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. examples/test_coordinate.ipynb has additional minor markdown detail

    @cavestruz
    cavestruz committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    5dd87bb View commit details
    Browse the repository at this point in the history

  2. merged non notebook files from Caio's branch so I can use the coordin… 

    …ate system in Tomomi's notebook
    @cavestruz
    cavestruz committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    94f8b9d View commit details
    Browse the repository at this point in the history

  3. test_coordinate.ipynb now runs from top to bottom using Caio's coordi… 

    …nate system implementation!
    @cavestruz
    cavestruz committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    d408582 View commit details
    Browse the repository at this point in the history

  4. adding additional docstrings to Tomomi's from-scratch calculation of … 

    …lensing from HSC data
    @cavestruz
    cavestruz committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    a64de00 View commit details
    Browse the repository at this point in the history

  5. refactoring code into functions to make loop over cluster lenses more… 

    … readable and some renaming of variables, e.g. sum to profile_sum, to avoid name space problems
    @cavestruz
    cavestruz committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    24b7e6f View commit details
    Browse the repository at this point in the history

  6. made additional refactoring changes, but refactored functions to calc… 

    …ulate angles between source and lens, etc. likely broke something in the background selection (now empty)
    @cavestruz
    cavestruz committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    4f753c2 View commit details
    Browse the repository at this point in the history

  7. some of the refactoring incorporated with pre-broken code

    @cavestruz
    cavestruz committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    74f559f View commit details
    Browse the repository at this point in the history

  8. cleaned up the loop over rbins

    @cavestruz
    cavestruz committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    79228d4 View commit details
    Browse the repository at this point in the history

  9. In line comments for portions of calculation

    @cavestruz
    cavestruz committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    8447b5d View commit details
    Browse the repository at this point in the history

  10. modified reverted commit to when the functions did not break, added i… 

    …n documentation and light refactoring from latest commit
    @cavestruz
    cavestruz committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    67bd568 View commit details
    Browse the repository at this point in the history

  11. merged fix from other branch with edits from previous commit

    @cavestruz
    cavestruz committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    b46d38d View commit details
    Browse the repository at this point in the history

  12. renamed the notebook for consistency

    @cavestruz
    cavestruz committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    695ee70 View commit details
    Browse the repository at this point in the history

  13. docs/doc-config.ini now includes the demo_coordinate_system notebook

    @cavestruz
    cavestruz committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    1885701 View commit details
    Browse the repository at this point in the history

  14. feat: Add coordinate_system parameter to compute_tangential_and_cross… 

    …_components and _compute_lensing_angles functions (#624)

* feat: Add coordinate_system parameter to compute_tangential_and_cross_components and _compute_lensing_angles functions

* Update documentation to account for new coordinate_system option

* feat: Add coordinate_system conversion test to test_compute_lensing_angles_flatsky function

* Add coordinate_system conversion test to test_compute_lensing_angles_astropy function and fix bug in coordinate system conversion bug in compute_lensing_angles_astropy

* Set coordinate_system option during creation of GalaxyCluster object

* Removed debuggin print in test_dataops.py

* Fixed typo and set default coordinate_system to "pixel"

* Added option to choose coordinate system for generated mock catalog

* Added ellipticity coordinate system conversion tests to test_galaxycluster.py and test_mockdata.py

* Fixed formatting

* Updated logic for lensing angle conversion between coordinate systems in _compute_lensing_angles_flatsky and updated tests

* Revert "Updated logic for lensing angle conversion between coordinate systems in _compute_lensing_angles_flatsky and updated tests"

This reverts commit 4a1faa6.

* Added coordinate_system validation and extra tests

* Changed example notebook to document new coordinate_system option

* Fixed all the documentation for coordinate_system and changed names from 'pixel'/'sky' to 'euclidean'/'celestial'

* Added reference for defitions of coordinate systems

* Fixed bug in coordinate system conversion in mock data generation

* Test ValueError raise for coordinate_system in test_mockdata.py

* Added more explanations about ellipticity coordinate system

* Fixed typo

* uodated tag to 1.12.4

---------

Co-authored-by: Marina Ricci <[email protected]>
    @caioolivv @marina-ricci
    caioolivv and marina-ricci authored Jul 18, 2024
    Configuration menu
    Copy the full SHA
    cf9e80c View commit details
    Browse the repository at this point in the history

  15. merged main

    @cavestruz
    cavestruz committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    f790e37 View commit details
    Browse the repository at this point in the history

  16. removed a character in a markdown cell that tests complained about in… 

    … making docs
    @cavestruz
    cavestruz committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    844e548 View commit details
    Browse the repository at this point in the history

  17. pulled with rebase of main

    @cavestruz
    cavestruz committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    40555d9 View commit details
    Browse the repository at this point in the history

  18. merged main again(?)

    @cavestruz
    cavestruz committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    31cde03 View commit details
    Browse the repository at this point in the history

  19. swapped pixel/euclidean and sky/celestial in notebook

    @cavestruz
    cavestruz committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    18778f4 View commit details
    Browse the repository at this point in the history

  20. pulled from main

    @cavestruz
    cavestruz committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    bf94e9d View commit details
    Browse the repository at this point in the history

  21. merged main from point where Caio's PR got merged to main

    @cavestruz
    cavestruz committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    2e150b8 View commit details
    Browse the repository at this point in the history

  22. reverted two files to try to match main

    @cavestruz
    cavestruz committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    3845e85 View commit details
    Browse the repository at this point in the history

  23. removed outputs in the notebook

    @cavestruz
    cavestruz committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    ffa22da View commit details
    Browse the repository at this point in the history

  24. removed OTHER notebook outputs

    @cavestruz
    cavestruz committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    35b2a2a View commit details
    Browse the repository at this point in the history

  25. remove empty cells in notebooks

    @cavestruz
    cavestruz committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    018d4ac View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. made minor edits in response to review, primarily with generalizing f… 

    …ile paths and removing comments or redundant text in the markdown
    @cavestruz
    cavestruz committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    7fe44dc View commit details
    Browse the repository at this point in the history

  2. incorporating original demo_mock_cluster.ipynb from main to remove ch… 

    …anges to the file in this branch that should not have been committed
    @cavestruz
    cavestruz committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    18325ff View commit details
    Browse the repository at this point in the history

  3. modified the Oguri example to also show incorrect coordinate assumpti… 

    …on as noted by Caio
    @cavestruz
    cavestruz committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    17fc2bf View commit details
    Browse the repository at this point in the history

  4. got rid of dollar signs inside markdown code snippet env hoping this … 

    …will get the checks passed
    @cavestruz
    cavestruz committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    2e5fb9b View commit details
    Browse the repository at this point in the history

  5. added review contributions line :-)

    @cavestruz
    cavestruz committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    0dec185 View commit details
    Browse the repository at this point in the history

  6. added a note for the CosmoDC2 clusters so the user is aware to not ne… 

    …cessarily expect a strong signal in center regions
    @cavestruz
    cavestruz committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    b1e9c72 View commit details
    Browse the repository at this point in the history

  7. removed extra cell at end

    @cavestruz
    cavestruz committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    328994e View commit details
    Browse the repository at this point in the history

  8. removed rogue savefig

    @cavestruz
    cavestruz committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    325f83f View commit details
    Browse the repository at this point in the history

  9. clarified why there might be less signal in the TXPipe outputted Cosm… 

    …oDC2 thing
    @cavestruz
    cavestruz committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    6953dbf View commit details
    Browse the repository at this point in the history

  10. Formatted demo_coordinate_system_datasets.ipynb notebook

    @caioolivv
    caioolivv committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    c87d95a View commit details
    Browse the repository at this point in the history