issue/627/testskypixelcoords: New notebook to test coordinate system effects with instructions to use example data #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_components and _compute_lensing_angles functions
…ngles_flatsky function
…astropy function and fix bug in coordinate system conversion bug in compute_lensing_angles_astropy
5 tasks
|
Changes unknown |
…uster.py and test_mockdata.py
…eed to incorporate Caio's added functionality for sky vs. pixel coordinates in CLMM
…lation of HSCY3 cluster without CLMM, but need to change colossus dependency because it is not easy to install on NERSC
…y dependency in notebook to the astropy one so this is easier to run on NERSC
…re-installing latest CLMM with Caio's added coordinate_system kwargs
… in _compute_lensing_angles_flatsky and updated tests
… systems in _compute_lensing_angles_flatsky and updated tests" This reverts commit 4a1faa6.
…ate system in Tomomi's notebook
|
Hi @cavestruz, for some reason the latest version of this branch doesn't have the current version of the |
caioolivv
requested changes
Jul 18, 2024
caioolivv
reviewed
Jul 19, 2024
caioolivv
requested changes
Jul 19, 2024
…ile paths and removing comments or redundant text in the markdown
…anges to the file in this branch that should not have been committed
…on as noted by Caio
…will get the checks passed
caioolivv
requested changes
Jul 19, 2024
examples/demo_mock_cluster.ipynb
Outdated
There was a problem hiding this comment.
I think the extra cells were added again 😢
There was a problem hiding this comment.
Sorry, outdated version
caioolivv
reviewed
Jul 19, 2024
| "ax.grid(which=\"minor\", lw=0.1)\n", | ||
| "plt.legend(fontsize=20)\n", | ||
| "plt.show()\n", | ||
| "plt.savefig('clmm_hsc_cluster.png')\n" |
There was a problem hiding this comment.
I think we shouldn't save the figure.
…cessarily expect a strong signal in center regions
caioolivv
approved these changes
Jul 19, 2024
cavestruz
approved these changes
Jul 19, 2024
m-aguena
pushed a commit
that referenced
this pull request
Aug 5, 2024
…effects with instructions to use example data (#629) * new notebook to test coordinate systems and shear measurements * editing README for the data availability * Added option to choose coordinate system for generated mock catalog * Added ellipticity coordinate system conversion tests to test_galaxycluster.py and test_mockdata.py * Added documentation to other test cases in Tomomi's notebook. Still need to incorporate Caio's added functionality for sky vs. pixel coordinates in CLMM * starting to work through and document example of lensing signal calculation of HSCY3 cluster without CLMM, but need to change colossus dependency because it is not easy to install on NERSC * added kwargs to GalaxyCluster instance definition in preparation for re-installing latest CLMM with Caio's added coordinate_system kwargs * test_coordinate.ipynb now runs from top to bottom using Caio's coordinate system implementation! * modified the Oguri example to also show incorrect coordinate assumption as noted by Caio * added a note for the CosmoDC2 clusters so the user is aware to not necessarily expect a strong signal in center regions * clarified why there might be less signal in the TXPipe outputted CosmoDC2 thing --------- Co-authored-by: Caio Lima de Oliveira <[email protected]> Co-authored-by: Camille Avestruz <[email protected]> Co-authored-by: Marina Ricci <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.