test: add reader test coverage #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damiramirez
reviewed
Jan 15, 2025
|
LGTM |
3 tasks
MegaRedHand
reviewed
Jan 16, 2025
MegaRedHand
reviewed
Jan 16, 2025
MegaRedHand
approved these changes
Jan 16, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed?
This PR adds more tests that increases the test coverage of
chainio/clients/elcontracts/reader_test.go, in a second PR there will be more coverage. Note: To execute some tests you'll need to remake the bindings (runmake bindings).The functions now covered are:
Note: This PR has some functionalities implemented in this other, so it would be good to merge that one before this one.
Reviewer Checklist