Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Dockerfiles #40

Merged
merged 3 commits into from
Jun 1, 2023
Merged

Improve Dockerfiles #40

merged 3 commits into from
Jun 1, 2023

Conversation

btlogy
Copy link
Contributor

@btlogy btlogy commented May 26, 2023

Preparation for #34

The goal of this PR is to rework the Dockerfile's before switching to rootless.

@btlogy btlogy force-pushed the 26.improve-dockerfiles branch from 7201808 to c34f07e Compare May 26, 2023 16:04
* avoid git package - unused since #30
* re-order and document steps
* use environment variables as parameter
* expose ports

Signed-off-by: Benoit Donneaux <[email protected]>
@btlogy btlogy force-pushed the 26.improve-dockerfiles branch 2 times, most recently from 0d3e29e to d0a29ec Compare May 26, 2023 22:18
@btlogy btlogy marked this pull request as ready for review May 26, 2023 22:23
@btlogy btlogy self-assigned this May 26, 2023
@btlogy btlogy requested a review from wuan May 26, 2023 22:46
Signed-off-by: Benoit Donneaux <[email protected]>
@btlogy btlogy requested review from a team and removed request for wuan May 30, 2023 19:38
@btlogy btlogy added the enhancement New feature or request label May 30, 2023
Signed-off-by: Benoit Donneaux <[email protected]>
Copy link

@c-chroniko c-chroniko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great

@btlogy btlogy merged commit 6699eef into main Jun 1, 2023
@btlogy btlogy deleted the 26.improve-dockerfiles branch June 1, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants