Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: πŸ”§ Upgrade Electron to v32 #7791

Closed
wants to merge 1 commit into from

chore: πŸ”§ Update Electron to v32

6e07c66
Select commit
Loading
Failed to load commit list.
Closed

chore: πŸ”§ Upgrade Electron to v32 #7791

chore: πŸ”§ Update Electron to v32
6e07c66
Select commit
Loading
Failed to load commit list.
live-github-bot / @Desktop β€’ Test App succeeded Sep 11, 2024 in 6m 0s

βœ… Success

Perform end to end and unit tests, type checks and run the linter on the Ledger Live Desktop application.

πŸ”— Workflow run

TypeCheck

Typechecks are fine

  • βœ… Type checks ended with status success

Unit Tests (Jest)

Unit tests are fine

  • βœ… Unit tests ended with status success

Screenshot Tests (Playwright)

🐧 Linux
❌ (failure)
Screenshots: ❌

It seems this PR contains screenshots that are different from the base branch.
If you are sure all those changes are correct, you can comment on this PR with /generate-screenshots to update those screenshots.

Make sure all the changes are correct before running the command, as it will commit and push the new result to the PR.

linux

Actual Diff Expected
market-page-filter-starred-actual market-page-filter-starred-diff market-page-filter-starred-expected
market-page-filter-starred-actual market-page-filter-starred-diff market-page-filter-starred-expected

Annotations

Check warning on line 113 in apps/ledger-live-desktop/tests/component/layout.component.ts

See this annotation in the file changed.

@live-github-bot live-github-bot / @Desktop β€’ Test App

@typescript-eslint/no-explicit-any

Unexpected any. Specify a different type.

Check warning on line 84 in apps/ledger-live-desktop/tests/fixtures/common.ts

See this annotation in the file changed.

@live-github-bot live-github-bot / @Desktop β€’ Test App

@typescript-eslint/no-explicit-any

Unexpected any. Specify a different type.

Check warning on line 18 in apps/ledger-live-desktop/tests/misc/reporters/step.ts

See this annotation in the file changed.

@live-github-bot live-github-bot / @Desktop β€’ Test App

@typescript-eslint/no-explicit-any

Unexpected any. Specify a different type.

Check warning on line 23 in apps/ledger-live-desktop/tests/misc/reporters/step.ts

See this annotation in the file changed.

@live-github-bot live-github-bot / @Desktop β€’ Test App

@typescript-eslint/no-explicit-any

Unexpected any. Specify a different type.

Check warning on line 5 in apps/ledger-live-desktop/tests/utils/customJsonReporter.ts

See this annotation in the file changed.

@live-github-bot live-github-bot / @Desktop β€’ Test App

@typescript-eslint/no-explicit-any

Unexpected any. Specify a different type.

Check warning on line 6 in apps/ledger-live-desktop/tests/utils/customJsonReporter.ts

See this annotation in the file changed.

@live-github-bot live-github-bot / @Desktop β€’ Test App

@typescript-eslint/no-explicit-any

Unexpected any. Specify a different type.

Check warning on line 6 in apps/ledger-live-desktop/tests/utils/fileUtils.ts

See this annotation in the file changed.

@live-github-bot live-github-bot / @Desktop β€’ Test App

@typescript-eslint/no-explicit-any

Unexpected any. Specify a different type.