Skip to content

Conversation

@bhimrazy
Copy link
Collaborator

@bhimrazy bhimrazy commented Oct 15, 2025

What does this PR do?

  • fix: unzip not found
.actions/pull_legacy_checkpoints.sh: line 10: unzip: command not found
total 0
+ cd tests/legacy
+ ls -lh checkpoints/
total 0
  • two of these tests seems to take more than 20 minutes but when run manually finished with in 5s [ debugging ]
============================= slowest 50 durations =============================
790.52s call     tests/tests_pytorch/models/test_torch_tensorrt.py::test_tensorrt_save_ir_type[ts-ScriptModule]
778.97s call     tests/tests_pytorch/models/test_torch_tensorrt.py::test_tensorrt_export_reload[ts-torchscript]
#manually

tests/tests_pytorch/models/test_torch_tensorrt.py::test_tensorrt_save_ir_type[default-GraphModule] PASSED
tests/tests_pytorch/models/test_torch_tensorrt.py::test_tensorrt_save_ir_type[dynamo-GraphModule] PASSED
tests/tests_pytorch/models/test_torch_tensorrt.py::test_tensorrt_save_ir_type[ts-ScriptModule] WARNING: [Torch-TensorRT] - For input x.1, found user specified input dtype as Float. The compiler is going to use the user setting Float
PASSED

================================================= 3 passed, 12 deselected, 2 warnings in 4.93s =================================================

Fixes #<issue_number>

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@bhimrazy bhimrazy changed the title chore debug gpu tests [wip]: chore/debug gpu tests Oct 15, 2025
@SkafteNicki SkafteNicki added the ci Continuous Integration label Oct 20, 2025
@bhimrazy bhimrazy marked this pull request as draft October 20, 2025 07:27
@bhimrazy
Copy link
Collaborator Author

bhimrazy commented Nov 2, 2025

It seems the delay in those tests is caused by CUDA_LAUNCH_BLOCKING=1.

Test Code

export CUDA_LAUNCH_BLOCKING=0
time python -c "
import torch
from lightning.pytorch.demos.boring_classes import BoringModel
model = BoringModel()
model.example_input_array = torch.randn((4, 32))
model.cuda()
print('Starting compilation with CI env vars...')
import time
start = time.time()
ret = model.to_tensorrt(ir='ts')
end = time.time()
print(f'Compilation took {end - start:.2f} seconds')
"

Almost 20 mins saved

@bhimrazy bhimrazy mentioned this pull request Nov 3, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants