-
Notifications
You must be signed in to change notification settings - Fork 464
New Metric: Upper Face Dynamics Deviation(FDD) #3238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
New Metric: Upper Face Dynamics Deviation(FDD) #3238
Conversation
f48ea3c
to
2a74503
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3238 +/- ##
=======================================
- Coverage 37% 37% -1%
=======================================
Files 364 351 -13
Lines 20096 19973 -123
=======================================
- Hits 7520 7350 -170
- Misses 12576 12623 +47 🚀 New features to boost your workflow:
|
45752a3
to
12cc909
Compare
@Borda The unittest error seems to coming from a timeout error from azure's end. Unrelated to the code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds the Upper Face Dynamics Deviation (FDD) metric for evaluating 3D talking head upper-face motion, including functional and class APIs, documentation, and tests.
- Introduces functional API upper_face_dynamics_deviation and class UpperFaceDynamicsDeviation
- Wires exports, adds docs and plotting test coverage, and updates changelog
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 13 comments.
Show a summary per file
File | Description |
---|---|
src/torchmetrics/functional/multimodal/fdd.py | Adds the functional FDD computation and docstring |
src/torchmetrics/multimodal/fdd.py | Adds the metric class implementation and plotting support |
src/torchmetrics/functional/multimodal/init.py | Exposes the new functional |
src/torchmetrics/multimodal/init.py | Exposes the new metric class |
src/torchmetrics/functional/init.py | Re-exports the functional at top-level |
tests/unittests/multimodal/test_fdd.py | Adds unit tests for class, functional, errors, differentiability, and plotting |
tests/unittests/utilities/test_plot.py | Adds the metric to generic plot tests |
docs/source/multimodal/fdd.rst | Adds user-facing docs for the metric |
docs/source/links.rst | Adds reference link for FDD |
CHANGELOG.md | Notes the new metric addition |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Correcting typos and mistakes in doctrings Co-authored-by: Copilot <[email protected]>
… device agnostic test implementation and correcting docstring mistakes
fdb763f
to
b3496d6
Compare
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
What does this PR do?
Implements the Upper Face Dynamics Deviation (FDD) metric for 3D talking head evaluation.
Computes the deviation in motion magnitude of upper-face vertices between predicted and ground truth meshes.
Fixes #3097
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--3238.org.readthedocs.build/en/3238/