-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove references to removed 'iocontrolv2' #3167
Remove references to removed 'iocontrolv2' #3167
Conversation
There are some other references to iocontrol-v2. I'm somewhat unclear about some of them (eg parameters 5600, 5601 or the comment in the various 'stdglue.py' files):
|
And with this PR: #2497 Not only iocontrol v2 also iocontrol. Then I wonder if the EMCIO parameter can be removed from all the sample configs?
Furthermore there are also the man pages of io and iov2 remaining. Can be removed as well? |
yes, can all be removed. |
ah, sorry no. the man pages should remain, as the pins are still there. |
I presume you mean the manpage for 'io' should remain and the one for 'iov2' can be removed? |
So it looks like I'm done (I assume that the files in the '/docs/po' folder are updated automatically) |
53a8799
to
c7706b7
Compare
yes |
It seems that something went wrong with your force push. |
c7706b7
to
fa16c27
Compare
With the removal of iocontrolv2 this line is no longer required.
Cleaned up, see #3169 |
Even though we don't have iov2 any more, I think we still support alternative io modules (if someone wants to write their own) |
Not sure we do still support alternative io modules as the 'EMCIO' entry seems to be ignored no matter what its value is. |
'iocontrol-v2' has been removed with this commit
9d79c2a