Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EMCIO] Remove various obsolete references to io and iov2 #3169

Merged
merged 11 commits into from
Nov 9, 2024

Conversation

Sigma1912
Copy link
Contributor

@Sigma1912 Sigma1912 commented Nov 2, 2024

This PR removes obsolete references to 'io' and 'iov2'

Background:
'io' and 'iov2' have been removed and their functionality moved to task:
9d79c2a

Discussion see:
#3167

@Sigma1912
Copy link
Contributor Author

Not sure why some of these tests are failing. Seems build and test just fine on my local machine.

@Sigma1912 Sigma1912 force-pushed the iocontrolv2_remove-references branch from 7cfc93d to 338390b Compare November 2, 2024 13:48
@andypugh
Copy link
Collaborator

andypugh commented Nov 2, 2024

Not sure why some of these tests are failing. Seems build and test just fine on my local machine.

When I last looked it seemed to be a problem with the Ubuntu VM not finding a Firefox snap to install.

@Sigma1912
Copy link
Contributor Author

Thanks for the comment. It seems to have smoothed itself out now.

@Sigma1912 Sigma1912 closed this Nov 3, 2024
@Sigma1912 Sigma1912 reopened this Nov 3, 2024
@hansu
Copy link
Member

hansu commented Nov 3, 2024

iocontrol.1.adoc can also be removed I think. But we should link iocontrol to io by adding it to the name section:

io(1)
NAME
+ io, iocontrol - interacts with HAL or G-code in non-realtime
- io - interacts with HAL or G-code in non-realtime

@hansu
Copy link
Member

hansu commented Nov 3, 2024

po4a.cfg:170: The master file 'src/man/man1/iocontrol.1.adoc' does not exist.

Sorry you have to remove it from the po4a.cfg as well.

@Sigma1912 Sigma1912 force-pushed the iocontrolv2_remove-references branch from 45c8f91 to 73c0d2d Compare November 3, 2024 10:39
@Sigma1912
Copy link
Contributor Author

Sigma1912 commented Nov 3, 2024

Looking at this commit by @rene-dev makes me think that the [EMCIO] 'CYCLE_TIME = 0.100' entry should also be removed.
27ef544#diff-53c30ad3a9ebf3f0b298246f7bec4fc2599bfdad79ae2334ed89dfad9ee6f2a6L1347

@rene-dev
Copy link
Member

rene-dev commented Nov 3, 2024

Yes, emcio cycle time can be removed as well.

@Sigma1912 Sigma1912 force-pushed the iocontrolv2_remove-references branch 2 times, most recently from 46a0031 to 1ce7981 Compare November 4, 2024 07:55
@Sigma1912 Sigma1912 changed the title Iocontrolv2 remove references [EMCIO] Remove various obsolete references to io and iov2 Nov 4, 2024
@Sigma1912 Sigma1912 force-pushed the iocontrolv2_remove-references branch 3 times, most recently from c99adb6 to 518c663 Compare November 4, 2024 09:29
@Sigma1912 Sigma1912 force-pushed the iocontrolv2_remove-references branch from 518c663 to c07fb12 Compare November 4, 2024 09:41
@Sigma1912
Copy link
Contributor Author

This is ready, as far as I'm concerned.

@rene-dev rene-dev merged commit 744b03e into LinuxCNC:master Nov 9, 2024
9 checks passed
@Sigma1912 Sigma1912 deleted the iocontrolv2_remove-references branch November 9, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants