-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EMCIO] Remove various obsolete references to io and iov2 #3169
[EMCIO] Remove various obsolete references to io and iov2 #3169
Conversation
Not sure why some of these tests are failing. Seems build and test just fine on my local machine. |
7cfc93d
to
338390b
Compare
When I last looked it seemed to be a problem with the Ubuntu VM not finding a Firefox snap to install. |
Thanks for the comment. It seems to have smoothed itself out now. |
io(1)
NAME
+ io, iocontrol - interacts with HAL or G-code in non-realtime
- io - interacts with HAL or G-code in non-realtime |
Sorry you have to remove it from the po4a.cfg as well. |
45c8f91
to
73c0d2d
Compare
Looking at this commit by @rene-dev makes me think that the [EMCIO] 'CYCLE_TIME = 0.100' entry should also be removed. |
Yes, emcio cycle time can be removed as well. |
With the removal of iocontrolv2 this line is no longer required.
46a0031
to
1ce7981
Compare
c99adb6
to
518c663
Compare
518c663
to
c07fb12
Compare
This is ready, as far as I'm concerned. |
This PR removes obsolete references to 'io' and 'iov2'
Background:
'io' and 'iov2' have been removed and their functionality moved to task:
9d79c2a
Discussion see:
#3167