integrate 0x v2 #278
integrate 0x v2 #278
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Deploying llamaswap with
|
| Latest commit: |
fea71bd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f5ee2cfb.llamaswap.pages.dev |
| Branch Preview URL: | https://0x-v2.llamaswap.pages.dev |
|
Note: Replace api key before merging |
| // check if permit2 contract approval address matches | ||
| if ( | ||
| permitApiQuote.permit2 !== null && | ||
| permitApiQuote.permit2.eip712.domain.verifyingContract.toLowerCase() !== permit2Address.toLowerCase() |
There was a problem hiding this comment.
this check seems useless? since verifyingContract is never used
There was a problem hiding this comment.
if user has enough allowance for permit2Address then permit2 will be null
no need for approval signature, but user can sign -> swap via permit2
instead of approving spender from allowanceHolderApiQuote -> swap
example: they approved on matcha.xyz or uniswap.org and trying to swap on llamaswap , we don't need to ask them to approve again
There was a problem hiding this comment.
PR looks good from my perspective!
I tried pulling the repo and testing but wasn't able to get the lambdas working (so in my tests, the lambdas were just pointed at prod). In my testing, it appeared the tx went down the AllowanceHolder flow just fine, which is sufficient to start.
That said, I was unable to test the permit2 flow. Happy to help out with testing if you guys need it
For now, things look good from our side - just requesting a rename from Argon => 'Matcha/0x v2'
Co-authored-by: phil-ociraptor <[email protected]>
This reverts commit cb53a25.
No description provided.