Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
integrate 0x v2 #278
base: master
Are you sure you want to change the base?
integrate 0x v2 #278
Changes from 17 commits
c66e398
c858fe7
fbf382e
7c473f6
22ca0c8
7fee618
9112df4
c77f0d3
a11fc47
6394919
7c9a89a
e6065fe
d893bfc
a2d40ce
04ed99a
f7928bc
7c1b013
01c28be
c98f50b
0a178ef
6812ae4
f6dc46d
33c1f7e
a17aa56
dca5bd9
63a4302
02939bb
cb53a25
fea71bd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this check seems useless? since verifyingContract is never used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if user has enough allowance for permit2Address then permit2 will be null
no need for approval signature, but user can sign -> swap via permit2
instead of approving spender from allowanceHolderApiQuote -> swap
example: they approved on matcha.xyz or uniswap.org and trying to swap on llamaswap , we don't need to ask them to approve again