-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop use of maap-py for obtaining S3 credentials #71
Conversation
S3 credentials are now obtained via a role using EC2 instance metadata. Fixes #14
I'm generally in favor of this for actual MAAP usage, but have concerns about removing the functionality to operate in a different way given the possibility of wanting to us this outside of MAAP, e.g. VEDA. |
Yes, there is a separate issue for refactoring for use outside of MAAP. When I work on that issue, I'll sort out how to make this modular. At the moment, I feel this simplification will better enable introducing modularization later. There will be less cruft to deal with. |
8e28e8f
to
fb650db
Compare
@wildintellect and @jjfrench, I've taken this PR out of Draft. It is now ready for review. I registered |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lookin good, thanks!
S3 credentials are now obtained via a role using EC2 instance metadata. In addition, removed HTTP retry logic since all granules are now obtained via S3 only.
Fixes #14