Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop use of maap-py for obtaining S3 credentials #71

Merged
merged 4 commits into from
May 9, 2024
Merged

Drop use of maap-py for obtaining S3 credentials #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3615e0c
Drop use of maap-py for obtaining S3 credentials
chuckwondo May 7, 2024
d702fbc
Handle AWS_PROFILE
chuckwondo May 7, 2024
fb650db
Move AWS_PROFILE assignment
chuckwondo May 8, 2024
62a4cfc
Remove explicit AWS_PROFILE
chuckwondo May 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,13 @@ The format is based on [Keep a Changelog], and this project adheres to

## Unreleased

### 0.7.0 (2024-04-23)
### Changed

- [#14](https://github.com/MAAP-Project/gedi-subsetter/issues/14) AWS S3
credentials are no longer obtained via the `maap-py` library. Instead, they
are obtained via a role using the EC2 instance metadata.

## 0.7.0 (2024-04-23)

### Added

Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ $(CONDA_PREFIX): bin/create
@bin/create

$(MAAP): $(CONDA_PREFIX) conda-lock.yml bin/install
@bin/install
@bin/install --dev

## lock: generate the lock file (conda-lock.yml) for the gedi_subset environment
# Simply a convenience target to generate the lock file since typing `make lock`
Expand Down
Loading