Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move raw_ vm operations to providers #571

Merged
merged 1 commit into from
Nov 12, 2019

Conversation

agrare
Copy link
Member

@agrare agrare commented Nov 1, 2019

All of these operations are overridden by the Vm subclass so there is no need to have the "parent" operations defined since run_command_via_parent isn't actually called.

ManageIQ/manageiq#19452

@agrare agrare added the wip label Nov 1, 2019
@agrare agrare force-pushed the extract_raw_vm_operations branch 2 times, most recently from 358f46b to 40ba820 Compare November 1, 2019 17:51
@agrare agrare changed the title [WIP] Move raw_ vm operations to providers Move raw_ vm operations to providers Nov 4, 2019
@agrare agrare removed the wip label Nov 4, 2019
@agrare agrare force-pushed the extract_raw_vm_operations branch 2 times, most recently from 55613de to b38059c Compare November 11, 2019 18:33
@miq-bot
Copy link
Member

miq-bot commented Nov 11, 2019

Checked commit agrare@b38059c with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

@Fryguy Fryguy merged commit d0e78fe into ManageIQ:master Nov 12, 2019
@Fryguy Fryguy added this to the Sprint 125 Ending Nov 25, 2019 milestone Nov 12, 2019
@agrare agrare deleted the extract_raw_vm_operations branch November 12, 2019 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants