Extract raw_* vm operations to providers #19452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrare
force-pushed
the
extract_raw_vm_operations_to_providers
branch
from
3d1fbdc to
82a7549
Compare
agrare
force-pushed
the
extract_raw_vm_operations_to_providers
branch
9 times, most recently
from
6b013b2 to
d293f6b
Compare
agrare
changed the title
This was referenced Nov 4, 2019
Merged
|
@Fryguy can you take a look? |
agrare
force-pushed
the
extract_raw_vm_operations_to_providers
branch
from
d293f6b to
6e492c1
Compare
Instead of having all of the raw_* operations defined in core calling run_command_via_parent, leave the raw_ operations undefined and allow them to be implemented in the different providers.
|
Checked commit agrare@6e492c1 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having all of the raw_* operations defined in core calling
run_command_via_parent, leave the raw_ operations undefined and allow
them to be implemented in the different providers.
Cross Repo Tests: ManageIQ/manageiq-cross_repo-tests#6
Pluggability Issue: #19440
Independent: (can be merged before or after this)
Move raw_ vm operations to providers manageiq-providers-amazon#571
Move raw_ vm operations to providers manageiq-providers-azure#361
Move raw_ vm operations to providers manageiq-providers-google#113
Depends: (these should be merged before this PR)
Extract raw_ vm operations to providers manageiq-providers-ovirt#422
Extract raw_ vm operations to providers manageiq-providers-scvmm#139
Move raw_* vm operations to provider repos manageiq-providers-vmware#470