Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update yarn to 4.0.0.rc51 since it's works on s390x #94

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Update yarn to 4.0.0.rc51 since it's works on s390x #94

merged 1 commit into from
Sep 19, 2023

Conversation

Fryguy
Copy link
Member

@Fryguy Fryguy commented Sep 18, 2023

Update yarn to 4.0.0.rc51 since it's works on s390x

@Fryguy Fryguy requested a review from agrare as a code owner September 18, 2023 20:44
@miq-bot
Copy link
Member

miq-bot commented Sep 18, 2023

Checked commit Fryguy@4577f29 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. ⭐

@miq-bot
Copy link
Member

miq-bot commented Sep 18, 2023

Some comments on commit Fryguy@4577f29

.yarn/releases/yarn-4.0.0-rc.51.cjs

  • ⚠️ - 12 - Detected pp. Remove all debugging statements.
  • ⚠️ - 132 - Detected pp. Remove all debugging statements.
  • ⚠️ - 134 - Detected pp. Remove all debugging statements.
  • ⚠️ - 288 - Detected pp. Remove all debugging statements.
  • ⚠️ - 291 - Detected pp. Remove all debugging statements.

@bdunne bdunne self-assigned this Sep 18, 2023
@bdunne bdunne merged commit ee90272 into ManageIQ:master Sep 19, 2023
3 checks passed
@Fryguy Fryguy mentioned this pull request Sep 25, 2023
Merged
12 tasks
@Fryguy
Copy link
Member Author

Fryguy commented Sep 25, 2023

Backported to quinteros in commit 76dbea6.

commit 76dbea6c33120b975c3b8ab670d33f75713dc637
Author: Brandon Dunne <[email protected]>
Date:   Tue Sep 19 09:57:43 2023 -0400

    Merge pull request #94 from Fryguy/yarn4
    
    Update yarn to 4.0.0.rc51 since it's works on s390x
    
    (cherry picked from commit ee90272eebc86e3542cc3488dd2d5a2487a94f79)

Fryguy pushed a commit that referenced this pull request Sep 25, 2023
@bdunne @Fryguy
Merge pull request #94 from Fryguy/yarn4
76dbea6 
Update yarn to 4.0.0.rc51 since it's works on s390x

(cherry picked from commit ee90272)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrare agrare Awaiting requested review from agrare agrare is a code owner

Assignees

@bdunne bdunne

Labels
dependencies quinteros/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fryguy @miq-bot @bdunne