Transfer IsoDatastore records to Storage and drop table

[nasark]

• schema changes to facilitate transfer of :iso_datastore records to :storage table
• iso datastores will be modelled as Storage objects with STI :type => ManageIQ::Providers::Ovirt::InfraManager::IsoDatastore

Depends on:

• Subclass IsoDatastore and transfer from core manageiq-providers-ovirt#621

@miq-bot add_labels enhancement, technical debt
@miq-bot assign @agrare

[kbrock]

• failure is legit but trivial - just need to remove the table from that list.
• cops hash/parens is legit byt trivial
• ignore timestamp cop

[agrare]

@nasark reminded me about the IsoImage model, so we'll need to:

1. Add a references to iso_images -> storages
2. Update all iso_images on the old iso_datastore to set the new storage_id column
3. Delete the iso_datastore_id from the iso_images before dropping the iso_datastores table

[Fryguy]

Was this table really just 2 columns (and id)? Seems almost pointless 😮

[agrare]

Yes there could only be one per EMS so there wasn't even an ems_ref or name "needed" even though it would be helpful

[nasark]

Thanks for the feedback all, I have made the changes and would appreciate another look whenever possible.

[agrare]

No need for .map if you aren't using the return

Suggested change

	emss.map do |ems|
	datastore_stub.create!(:ext_management_system => ems)
	end
	emss.each { |ems| datastore_stub.create!(:ext_management_system => ems) }

[agrare]

@nasark can we add specs covering the IsoImage changes as well?

[miq-bot]

Checked commit nasark@e3385a5 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
3 files checked, 1 offense detected

db/migrate/20221107195559_drop_iso_datastore.rb

• ❗ - Line 11, Col 7 - Rails/CreateTableWithTimestamps - Add timestamps when creating a new table.