Cockpit is a monitor thread and is not a pod worker. #20823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtanzillo
approved these changes
Nov 18, 2020
Follow up to ManageIQ#20792 It runs in the orchestrator in pods in a thread and launches a process to communicate with cockpit. The threaded worker monitors this process, has a miq_workers row, but does not run in a separate pod and therefore doesn't currently update the row with it's pod name. Therefore, we need to exclude cockpit rows from the code that monitors for orphaned pod miq_workers. In the future, we could populate the cockpit miq_workers row with the pod name of the orchestrator pod it's running on but that would be a larger change and perhaps we should discuss that with a larger discussion about cockpit and if it works as we want in pods.
jrafanie
force-pushed
the
cockpit_is_not_a_pod_worker
branch
from
2c29836 to
b9f8913
Compare
seriously... Ok, fine, pushed using the second most popular form in the rails codebase. |
|
Checked commit jrafanie@b9f8913 with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint |
|
I'll check if this is a straight backport to jansa |
|
It's not a straight backport, I'll open a jansa PR |
|
opened #20827 for the jansa version of this PR |
simaishi
pushed a commit
that referenced
this pull request
Nov 19, 2020
Cockpit is a monitor thread and is not a pod worker. (cherry picked from commit 90c2323)
|
Kasparov backport details: |
simaishi
added a commit
that referenced
this pull request
Nov 19, 2020
…rker [JANSA] Cockpit is a monitor thread and is not a pod worker. #20823 jansa backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #20792
It runs in the orchestrator in pods in a thread and launches a process to communicate with cockpit.
The threaded worker monitors this process, has a miq_workers row, but does not run in a separate pod
and therefore doesn't currently update the row with it's pod name. Therefore, we need to exclude cockpit
rows from the code that monitors for orphaned pod miq_workers.
In the future, we could populate the cockpit miq_workers row with the pod name of the orchestrator pod it's
running on but that would be a larger change and perhaps we should discuss that with a larger discussion about
cockpit and if it works as we want in pods.