[JANSA] Cockpit is a monitor thread and is not a pod worker. #20823 jansa backport #20827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up to ManageIQ#20792 [Modified for jansa to use guid column instead of system_uid] It runs in the orchestrator in pods in a thread and launches a process to communicate with cockpit. The threaded worker monitors this process, has a miq_workers row, but does not run in a separate pod and therefore doesn't currently update the row with it's pod name. Therefore, we need to exclude cockpit rows from the code that monitors for orphaned pod miq_workers. In the future, we could populate the cockpit miq_workers row with the pod name of the orchestrator pod it's running on but that would be a larger change and perhaps we should discuss that with a larger discussion about cockpit and if it works as we want in pods.
jrafanie
requested review from
carbonin,
Fryguy and
gtanzillo
as code owners
gtanzillo
approved these changes
Nov 18, 2020
|
I'm running an image build of jansa with this PR to make sure cockpit starts and is excluded from the miq_workers pod row syncup |
ok, this PR corrects the constant restarts of the cockpit "worker" due to the worker being removed. It doesn't work in pods right now but at least it doesn't thrash the system (like it did before this PR), compromising the orchestrator pod. Note, cockpit has lots of problems in pods and we should consider if it's something that can work and if that effort is desired. At the very least, I wonder if we should disable the role in pods so you can't activate a broken role. See: #20829 |
Fryguy
approved these changes
Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #20792
[Modified for jansa to use guid column instead of system_uid]
jansa backport of #20823
It runs in the orchestrator in pods in a thread and launches a process to communicate with cockpit.
The threaded worker monitors this process, has a miq_workers row, but does not run in a separate pod
and therefore doesn't currently update the row with it's pod name. Therefore, we need to exclude cockpit
rows from the code that monitors for orphaned pod miq_workers.
In the future, we could populate the cockpit miq_workers row with the pod name of the orchestrator pod it's
running on but that would be a larger change and perhaps we should discuss that with a larger discussion about
cockpit and if it works as we want in pods.
EDIT:
This PR corrects the problem for this issue. It doesn't fix cockpit in pods but it resolves the constant restarts.