Fix MeshShape::clear() for safer mesh removal (moveit#3164)

Added a check to retrieve the mesh by name before attempting to remove it.
MarqRazz · Dec 16, 2024 · f91a650 · f91a650
1 parent abb440d
commit f91a650
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/moveit_ros/visualization/rviz_plugin_render_tools/src/mesh_shape.cpp b/moveit_ros/visualization/rviz_plugin_render_tools/src/mesh_shape.cpp
@@ -140,7 +140,11 @@ void MeshShape::clear()
   if (entity_)
   {
     entity_->detachFromParent();
-    Ogre::MeshManager::getSingleton().remove(entity_->getMesh()->getName());
+    const auto& mesh_name = entity_->getMesh()->getName();
+    if (Ogre::MeshPtr mesh = Ogre::MeshManager::getSingleton().getByName(mesh_name))
+    {
+      Ogre::MeshManager::getSingleton().remove(mesh);
+    }
     scene_manager_->destroyEntity(entity_);
     entity_ = nullptr;
   }