Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbol init cleanup 2 #691

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Symbol init cleanup 2 #691

wants to merge 12 commits into from

Conversation

rocky
Copy link
Member

@rocky rocky commented Dec 27, 2022

Thanks @mmatera to getting this to the point where I can see the light at the end of the tunnel.

rocky and others added 11 commits January 7, 2023 08:22
PredefinedSymbol acts more like a numeric constant.
Update builtin/atomic/symbols.py according to current standards.
* Some long lines split
* some linting
* correct a wrong symbol
We should be using Symbols insead of string where possible.
builtins_precedence is really used in eval/makeboxes so it is defined
there.

It is just initialized in `mathics.buitins`.
and try to clearify what is up here.
@rocky
Copy link
Member Author

rocky commented Jan 7, 2023

@mmatera I have rebased this with the current master and made small changes to get this working.

Please look over all of the boxing changes here and advise if this is relevant, correct, and should go in.

@rocky
Copy link
Member Author

rocky commented Jan 7, 2023

@mmatera I have rebased this with the current master and made small changes to get this working.

Please look over all of the boxing changes here and advise if this is relevant, correct, and should go in.

Looking over myself, I am happy to put in a new PR with the boxing stuff removed until after release. I don't fully understand this, and the focus of this PR of this wasn't about boxing which somehow slipped in here as a bug fix for the Symbol work.

@mmatera
Copy link
Contributor

mmatera commented Jan 7, 2023

@rocky, as you prefer. The idea was to move out of mathics.builtin.makeboxes the implementation of parenthesize and make_boxes_infix, in the line of moving the evaluation logic outside the mathics.builtin module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants