Skip to content
This repository has been archived by the owner on Jul 22, 2021. It is now read-only.

Remove useless files #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove useless files #12

wants to merge 1 commit into from

Conversation

hardion
Copy link
Member

@hardion hardion commented Oct 7, 2019

There are non generic script that should not be part of this project.

@hardion hardion requested a review from AntoineDupre October 7, 2019 14:50
@SKAJohanVenter
Copy link

The setup.py will also have to be modified to remove the entry_points that are no longer available.

@SKAJohanVenter
Copy link

Is ./dsconfig/remove.py still valid ? It seems to be broken.

Traceback (most recent call last):
  File "./dsconfig/remove.py", line 6, in <module>
    from utils import (ObjectWrapper, decode_dict, get_dict_from_db,
ImportError: cannot import name decode_dict

@ajoubertza
Copy link

@hardion @AntoineDupre Can you please have a look at this? We'll be continuing dsconfig work in our next sprint, migrating to Python 3.

@ajoubertza
Copy link

This appears to have been partly addressed by #14. Although that PR didn't remove dsconfig/excel.py. Also, the setup.py file still points to entry points that no longer exist.

entry_points={
"console_scripts": ["xls2json = dsconfig.excel:main",
"csv2json = dsconfig.callcsv:main",
"json2tango = dsconfig.json2tango:main"]

In the develop branch, we would need to remove at least csv2json = dsconfig.callcsv:main. In this PR, we would also need to remove xls2json = dsconfig.excel:main.

This was referenced Aug 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants