Python 3.6 compatibility #14
Conversation
Issue related to pytest-dev/pluggy#205 This should be resolved once we have ported to Python3 completely.
So that Gitlab CI can parse it.
We want to always integrate with master from the mirror.
|
@wkitka Thanks - we (SKA) were planning to do this long ago, but never got time to finish it. We did add some tests as we wanted to increase the test coverage before migrating. Those are in a mirrored repo: https://gitlab.com/ska-telescope/lib-maxiv-dsconfig/-/tree/SAR-2/expand_test_coverage. You may want to include those, or at least try them out against your new code. Note that some of the files are no longer needed - there is an open PR removing them: #12. Would you mind filling in the description for this PR? For example, is this update dropping support for Python 2, or is it now compatible with both 2.7 and 3.6? Any limitations? Etc. |
| version="1.4.0", | ||
| packages=['dsconfig', 'dsconfig.appending_dict'], | ||
| version="1.5.0", | ||
| packages=["dsconfig", "dsconfig.appending_dict"], | ||
| description="Library and utilities for Tango device configuration.", | ||
| # Requirements |
There was a problem hiding this comment.
Adding a python_requires line would be good.
For example:
https://github.com/pypa/sampleproject/blob/150be5fc818484b78816529bc9ec59440a9bcdab/setup.py#L137
There was a problem hiding this comment.
Thanks for comments! I'll improve this PR.
There was a problem hiding this comment.
I included both mentioned PRs and added description
|
Hej, It looks also good from my side, shall we proceed to the merge? |
Hej @bamartos |
There was a problem hiding this comment.
Thanks @wkitka
Fingers crossed (since this repo has no CI!) 🙂
|
@bamartos |
Make dsconfig compatible with Python 3.6 and drop support for Python 2.
Tested features: xls2json, json2tango, dsconfig.dump, dsconfig.viewer.