-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: port pp update #43
Conversation
rosu-pp/src/osu/performance/mod.rs Lines 640 to 641 in 674cbec
Should this be something like |
That's true, good catch 😄
Actually, the data dump already includes scores with data post-update so I wrote a test suite which already caught a bunch of bugs and should give a lot more confidence in my implementation. |
The score 3051169674 causes intermediate negative values but still a positive value overall so we need to cast to i32.
Checklist