Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Application] Fix securityContext for sidecars #163

Merged
merged 4 commits into from
Dec 3, 2024

Conversation

knabben-mms
Copy link
Contributor

The previous implementation did override the default value which then were applied to the next sidecar if no securityContext was set for this sidecar.

@knabben-mms knabben-mms requested a review from a team as a code owner November 27, 2024 13:06
@technolinator-sbom-as-a-service
Copy link

technolinator-sbom-as-a-service bot commented Nov 27, 2024

🏆 No vulnerabilities found

heubeck
heubeck previously approved these changes Nov 27, 2024
@heubeck heubeck changed the title Fix securityContext for sidecars [Application] Fix securityContext for sidecars Nov 27, 2024
@heubeck heubeck enabled auto-merge December 3, 2024 07:06
@heubeck heubeck disabled auto-merge December 3, 2024 07:08
@heubeck heubeck force-pushed the knabben-fixsecuritycontext branch from f32c56b to f10c7b1 Compare December 3, 2024 07:10
@heubeck heubeck enabled auto-merge December 3, 2024 07:10
@heubeck heubeck disabled auto-merge December 3, 2024 07:23
@heubeck heubeck enabled auto-merge (squash) December 3, 2024 07:24
@heubeck heubeck disabled auto-merge December 3, 2024 07:26
@heubeck heubeck enabled auto-merge (squash) December 3, 2024 07:26
@heubeck heubeck merged commit f586829 into main Dec 3, 2024
11 of 18 checks passed
@heubeck heubeck deleted the knabben-fixsecuritycontext branch December 3, 2024 07:36
@stuebingerb
Copy link
Contributor

Shouldn't there be a corresponding test case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants