Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing UPROPERTY and const keywords in some places #63

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

zompi2
Copy link

@zompi2 zompi2 commented Feb 14, 2024

  1. There was no UPROPERTY() in the FLifeTimeFragment
  2. In UE 5.3.2 the BuildTemplate and ValidateTemplate requires const UWorld& instad of UWorld&

@Megafunk
Copy link
Owner

What does adding reflection to the float in FLifeTimeFragment help with exactly? I assume it's needed for hashing of some sort?

@zompi2
Copy link
Author

zompi2 commented Feb 15, 2024

Actually I think it doesn't help with anything in particular, but in the next example the float Distance is marked as an UPROPERTY too and I thought it'd be good to keep things consistent.

@vorixo
Copy link
Collaborator

vorixo commented Feb 15, 2024

Hey @zompi2 the point on having divergent examples is to show that you are not forced to make the variables in fragments UPROPERTY(es).

@zompi2
Copy link
Author

zompi2 commented Feb 16, 2024

Ok, I understand now. I removed that UPROPERTY. Just added an extra space, because for someone new (like myself) the GENERATED_BODY right over the variable looked odd :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants