Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing UPROPERTY and const keywords in some places #63

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Missing UPROPERTY and const keywords in some places #63

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
449fc6e
missing uproperty and const keywords in some places
Feb 14, 2024
bdef149
no UPROPERTY here then
Feb 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,7 @@ USTRUCT()
struct MASSCOMMUNITYSAMPLE_API FLifeTimeFragment : public FMassFragment
{
GENERATED_BODY()

float Time;
};
```
Expand Down Expand Up @@ -783,7 +784,7 @@ class MASSCOMMUNITYSAMPLE_API UMSDebugTagTrait : public UMassEntityTraitBase
{
GENERATED_BODY()
public:
virtual void BuildTemplate(FMassEntityTemplateBuildContext& BuildContext, UWorld& World) const override
virtual void BuildTemplate(FMassEntityTemplateBuildContext& BuildContext, const UWorld& World) const override
{
// Adding a tag
BuildContext.AddTag<FMassSampleDebuggableTag>();
Expand Down Expand Up @@ -829,7 +830,7 @@ Traits can override `ValidateTemplate` to provide custom validation code for the

In the following snippet, we check if a field of the trait is `nullptr` and log an error:
```c++
void UMSNiagaraRepresentationTrait::ValidateTemplate(FMassEntityTemplateBuildContext& BuildContext, UWorld& World) const
void UMSNiagaraRepresentationTrait::ValidateTemplate(FMassEntityTemplateBuildContext& BuildContext, const UWorld& World) const
{
// If our shared niagara system is null, show an error!
if (!SharedNiagaraSystem)
Expand Down