Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove access token thats unnecessary (GA4) #159

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

pnadolny13
Copy link
Collaborator

@pnadolny13 pnadolny13 commented Mar 11, 2024

The method that was previously used to manage OAuth tokens had issues with refreshing (see #155) and it expected an access token to be provided which is unnecessary.

I was able to sync data from a test account using these changes. I think the CI job only uses client_secrets.json.

Copy link

sonarcloud bot commented Mar 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@pnadolny13 pnadolny13 changed the title chore: remove access token thats unnecessary chore: remove access token thats unnecessary (GA4) Mar 11, 2024
@pnadolny13 pnadolny13 merged commit 9eb6d00 into main Mar 12, 2024
9 checks passed
@pnadolny13 pnadolny13 deleted the remove_access_token branch March 12, 2024 15:01
pnadolny13 added a commit that referenced this pull request Mar 12, 2024
This makes the same changes as
#159 but on the
UA branch.

---------

Co-authored-by: Edgar Ramírez Mondragón <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant