Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 7.37.0 #12490

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

feat: 7.37.0 #12490

wants to merge 4 commits into from

Commits on Nov 28, 2024

  1. Configuration menu
    Copy the full SHA
    8a7f092 View commit details
    Browse the repository at this point in the history
  2. chore: chore/7.37.0-Changelog (#12491)

    This PR updates the change log for 7.37.0 and generates the test plan
    here
    [commit.csv](https://github.com/MetaMask/metamask-mobile/blob/release/7.37.0/commits.csv)
    
    ---------
    
    Co-authored-by: metamaskbot <[email protected]>
    Co-authored-by: sethkfman <[email protected]>
    3 people authored Nov 28, 2024
    Configuration menu
    Copy the full SHA
    e958128 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2024

  1. chore(runway): cherry-pick feat: implement remote feature flag contro…

    …ller (#12510)
    
    - feat: implement remote feature flag controller (#12427)
    
    <!--
    Please submit this PR as a draft initially.
    Do not mark it as "Ready for review" until the template has been
    completely filled out, and PR status checks have passed at least once.
    -->
    
    ## **Description**
    
    <!--
    Write a short description of the changes included in this pull request,
    also include relevant motivation and context. Have in mind the following
    questions:
    1. What is the reason for the change?
    2. What is the improvement/solution?
    -->
    
    Introduction of `@metamask/remote-feature-flag-controller` library.
    
    Remote feature flag controller manages data flow, retry policy, and
    cache expiry.
    The controller consumer manages default values, data persistency, and
    data distribution.
    
    See
    
    [ADR](https://github.com/MetaMask/decisions/blob/b3094d47a568ac1e076a44fa704c2d29d1b59f35/decisions/wallet-platform/0001-remote-rollout-feature-flags.md)
    for a in-depth description
    
    ## Technical decisions
    
    ### Controller init on `Engine.ts` with feature flags fetching only on
    cold app starts.
    
    `@metamask/remote-feature-flag-controller` is only asked to fetch
    feature flags after its init in `Engine.ts`. Ensures feature flags are
    only fetched on cold app starts.
    
    ### Fallback values
    
    Default values are used when remote feature flags are undefined.
    The fallback mechanism is implemented by each feature flag selector
    `app/selectors/featureFlagsController/<featureFlagName>`
    
    In this PR we include `minimumAppVersion` selector, which manages the LD
    feature flag `mobile-minimum-versions`
    
    ### One selector per each feature flag
    
    [LD feature flags can be boolean, number, strings on JSON
    
    objects](https://docs.launchdarkly.com/sdk/concepts/flag-types#understanding-flag-types).
    We've decided to have each feature flag with its own selector
    
    A feature flag selector contains:
    - state selectors for each feature flag value.
    - business logic
    - defaults for when feature flags values are undefined.
    - TS types.
    - unit tests and mocked data.
    
    This architecture offers a clear separation between each feature flag
    and the logic behind it, allowing easier manipulation.
    Code owners are assigned to each feature flag.
    
    ### 
    
    ## **Related issues**
    
    Fixes: https://github.com/MetaMask/mobile-planning/issues/2054
    Fixes: https://github.com/MetaMask/mobile-planning/issues/1975
    
    ## **Manual testing steps**
    
    1. Go to this page...
    2.
    3.
    
    ## **Screenshots/Recordings**
    
    <!-- If applicable, add screenshots and/or recordings to visualize the
    before and after of your change. -->
    
    ### **Before**
    
    <!-- [screenshots/recordings] -->
    
    ### **After**
    
    <!-- [screenshots/recordings] -->
    
    ## **Pre-merge author checklist**
    
    - [ ] I’ve followed [MetaMask Contributor
    Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
    Coding
    
    Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
    - [ ] I've completed the PR template to the best of my ability
    - [ ] I’ve included tests if applicable
    - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
    if applicable
    - [ ] I’ve applied the right labels on the PR (see [labeling
    
    guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
    Not required for external contributors.
    
    ## **Pre-merge reviewer checklist**
    
    - [ ] I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
    - [ ] I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.
    
    ---------
    
    Co-authored-by: Nico MASSART <[email protected]>
    Co-authored-by: tommasini <[email protected]>
    [a8c0783](a8c0783)
    
    Co-authored-by: João Loureiro <[email protected]>
    Co-authored-by: Nico MASSART <[email protected]>
    Co-authored-by: tommasini <[email protected]>
    4 people authored Dec 2, 2024
    Configuration menu
    Copy the full SHA
    18aca38 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e7b65d5 View commit details
    Browse the repository at this point in the history