1.36.4 Turn off must predraw, more breadcrumbs for atlasURI not defined

MikalDev · Feb 13, 2021 · d72f850 · d72f850
1 parent 53321bf
commit d72f850
Show file tree

Hide file tree

Showing 6 changed files with 15 additions and 6 deletions.
diff --git a/dist/Spine-v1.36.4.c3addon b/dist/Spine-v1.36.4.c3addon
diff --git a/src/addon.json b/src/addon.json
@@ -3,7 +3,7 @@
   "type": "plugin",
   "name": "Spine",
   "id": "Gritsenko_Spine",
-  "version": "1.36.3",
+  "version": "1.36.4",
   "author": "Mikal and Igor Gritsenko",
   "website": "https://gritsenko.github.io/c3_spine_plugin",
   "documentation": "https://gritsenko.github.io/c3_spine_plugin",

diff --git a/src/c3runtime/instance.js b/src/c3runtime/instance.js
@@ -165,8 +165,15 @@
             // Sentry error reported
             if (atlasURI === undefined || atlasURI === null)
             {
-                console.warn('[Spine] loadSkeletonData, atlasURI not set', atlasURI, assetTag, this.atlasURI, assetManager.isLoadingComplete(assetTag), this.atlasPath);
+                console.warn('[Spine] loadSkeletonData, atlasURI not set', atlasURI, assetTag, this.atlasURI, assetManager.isLoadingComplete(assetTag), this.atlasPath, this.runtime.GetTickCount());
+                console.warn('[Spine] objectclass',this.GetInstance().GetObjectClass().GetName(), this.GetInstance().GetSDKType(), this.runtime.GetTickCount());
+                if (globalThis.Sentry)
+                {
+                    globalThis.Sentry.captureException('[Spine] loadSkeletonData, atlasURI not set, object:'+this.GetInstance().GetObjectClass().GetName());
+                }
+                return;
             }
+
             this.sdkType._atlas = new spine.TextureAtlas(atlasURI, function(path) {
                 return assetManager.get(self.sdkType._assetTag, self.sdkType._assetPaths[path]);
             });
@@ -207,7 +214,7 @@
         }
 
         loadSkeleton(name, animationName, sequenceSlots) {
-            if (this.debug) console.info("[Spine] Reading skeleton data:", this.uid, name, animationName);
+            if (this.debug) console.info("[Spine] Reading skeleton data:", this.uid, this.sdkType.GetObjectClass().GetName(), animationName);
             // If skeletonData not initialized, create it and stop other instances from creating it
 
             let skeleton = new spine.Skeleton(this.sdkType._skeletonData);

diff --git a/src/c3runtime/spine-draw.js b/src/c3runtime/spine-draw.js
@@ -305,6 +305,6 @@ class SpineBatch {
 
 if (!globalThis.spineBatcher)
 {
-    console.log('[Spine] SpineBatcher init, 1.36.3');
+    console.log('[Spine] SpineBatcher init, 1.36.4');
     globalThis.spineBatcher = new SpineBatch();
 }
diff --git a/src/c3runtime/type.js b/src/c3runtime/type.js
@@ -11,11 +11,13 @@
 
         Release()
         {
+            console.warn('[Spine] type.Release', this.GetObjectClass().GetName(), this._runtime.GetTickCount())
             super.Release();
         }
 
         OnCreate()
         {
+            console.info('[Spine] type.OnCreate', this.GetObjectClass().GetName(), this._runtime.GetTickCount())
             this.GetImageInfo().LoadAsset(this._runtime);
             this._skeletonDataInitialized = false;
             this._skeletonDataInitializing = false;

diff --git a/src/plugin.js b/src/plugin.js
@@ -3,7 +3,7 @@
     const C3 = self.C3;
 
     const PLUGIN_ID = "Gritsenko_Spine";
-    const PLUGIN_VERSION = "1.36.3";
+    const PLUGIN_VERSION = "1.36.4";
     const PLUGIN_CATEGORY = "general";
 
     const PLUGIN_CLASS = SDK.Plugins.Gritsenko_Spine = class SpinePlugin extends SDK.IPluginBase {
@@ -23,7 +23,7 @@
             this._info.SetIsRotatable(true); // allow to be rotated
             this._info.SetHasImage(true);
             this._info.SetSupportsEffects(true); // allow effects
-            this._info.SetMustPreDraw(true);
+            this._info.SetMustPreDraw(false);
             this._info.AddCommonPositionACEs();
             this._info.AddCommonAngleACEs();
             this._info.AddCommonAppearanceACEs();