Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/GitHub workflow #272

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

phibos
Copy link
Contributor

@phibos phibos commented Jul 1, 2021

Add a github workflow to run phpcs and phplint. The config has been adapted from other icingaweb2 modules.

Things done:

  • convert all files to unix line endings
  • fix long lines
  • fix warnings and errors from phpcs and phplint

@phibos
Copy link
Contributor Author

phibos commented Jul 6, 2021

@Mikesch-mp Please feel free to contact me if you have any questions.

@phibos
Copy link
Contributor Author

phibos commented Aug 25, 2021

@Mikesch-mp are there any plans to merge this? If yes I can fix the merge conflicts and if not this request can be closed.

1 similar comment
@phibos
Copy link
Contributor Author

phibos commented Nov 19, 2021

@Mikesch-mp are there any plans to merge this? If yes I can fix the merge conflicts and if not this request can be closed.

@phibos
Copy link
Contributor Author

phibos commented Aug 29, 2022

@Mikesch-mp if you are still interested in this CI pipeline I can rebase it or if you don't like it I can close the PR.

@Mikesch-mp
Copy link
Owner

Can you please redo it after i released 2.0.0?

@Mikesch-mp Mikesch-mp self-assigned this Feb 23, 2023
@Mikesch-mp Mikesch-mp added this to the 2.0.1 milestone Feb 23, 2023
@Mikesch-mp Mikesch-mp removed this from the 2.0.1 milestone Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants